Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Apr 2017 13:59:29 -0700
From:      "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To:        rgrimes@freebsd.org
Cc:        Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r317290 - head/tools/regression/geom_gpt
Message-ID:  <3238ED82-1FAA-4E7C-81B9-A9E9E417E860@gmail.com>
In-Reply-To: <201704222006.v3MK6fYX047692@pdx.rh.CN85.dnsmgr.net>
References:  <201704222006.v3MK6fYX047692@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_FE4CD735-896B-4905-8281-979374D404D9
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Apr 22, 2017, at 13:06, Rodney W. Grimes =
<freebsd@pdx.rh.CN85.dnsmgr.net> wrote:
>=20
>> Author: ngie
>> Date: Sat Apr 22 20:00:52 2017
>> New Revision: 317290
>> URL: https://svnweb.freebsd.org/changeset/base/317290
>>=20
>> Log:
>>  Fix -Wimplicit-function-declaration compilation warning by moving =
libgeom.h
>>  #include below the stdio.h #include.
>>=20
>>  gctl_dump(3) needs stdio.h, per reasoning noted in r317289.
>>=20
>>  MFC after:	5 weeks
>>  PR:		218809
>>  Submitted by:	Chang-Hsien Tsai <luke.tw@gmail.com>
>>  Sponsored by:	Dell EMC Isilon
>>=20
>> Modified:
>>  head/tools/regression/geom_gpt/test.c
>>=20
>> Modified: head/tools/regression/geom_gpt/test.c
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/tools/regression/geom_gpt/test.c	Sat Apr 22 19:32:23 2017	=
(r317289)
>> +++ head/tools/regression/geom_gpt/test.c	Sat Apr 22 20:00:52 2017	=
(r317290)
>> @@ -29,12 +29,12 @@ __FBSDID("$FreeBSD$");
>>=20
>> #include <sys/param.h>
>> #include <errno.h>
>> -#include <libgeom.h>
>> #include <limits.h>
>> #include <stdio.h>
>> #include <stdlib.h>
>> #include <string.h>
>> #include <unistd.h>
>> +#include <libgeom.h>
> #include <libgeom.h>	/* This is not in alphabetic order per r317289 =
*/
>>=20
>> struct retval {
>> 	struct retval *retval;
>=20
> Might it be a good idea to mark this in the test.c file as to why
> these are not sorted in order to prevent regressions of this in
> the future?

Please see r317289. There was an omission in the documentation that =
allowed this to happen.

This also won=E2=80=99t happen again given that the test is now being =
compiled with WARNS?=3D 6 :).

-Ngie

--Apple-Mail=_FE4CD735-896B-4905-8281-979374D404D9
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJY+8QxAAoJEPWDqSZpMIYVg3oQAJXWvqhBMF2vVI9deaeRO1OR
op1hutymdCABzoQBME+7sVHYZLxCPFBqShtEu5/1TPBaIBKlnVx2cFjKstAvyeaj
7j1+qiO+xh4x6FpknZUNf380A8P9R5zk5o9ZKx6SBAQvGZHHgs7JSXdWyhsMaAcq
DHejMJp6nut/nuy5h2PSE4T97n3YgpdIOeiLVAGaYamdkvwht3I2uN6grB6GhDPy
NjN9zUBVXA3Z0rNU+WoJQtVnTgtPUVXu++GJxKpg4zyHNwvJ1HqsISUcvD/QwXlB
UFpLifVUUNM13rfC7q64tHNu7WVsDOlzI9c7MtlsEO2lqqCDHh49Ie6NaXVnRD5p
E0tQjlTlU//Y0JO2AkIup+fgoFqEt0CrkVbvKe+RgmifeaVrHQd4v1KFNF9iz77U
pvk8PKNFu/fNFmqUj1TulNl5yikuFsRj4tpD1iJSllrJgp35UfTDWZvU+4txT8kr
5+VldmKnsRWg/z4JUwYsE4whyyPfzSDVyh99xy/jJKmETxbocv7maDOvYYVZeWu1
b5tgfDXGU5AYZy1gLZxXTgNb+qf14USyOxB0cAkS5ygDOIFKDkYS3384N5V46+/Q
MAleFCfz8sJzXMzoTIoxm6+EqSeM6jVxRS8e3nk1YnpvNPTsSaxSugottRgs7iNv
/AvAB7IoJLNfgYo8yFvI
=ltO5
-----END PGP SIGNATURE-----

--Apple-Mail=_FE4CD735-896B-4905-8281-979374D404D9--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3238ED82-1FAA-4E7C-81B9-A9E9E417E860>