Date: Sun, 22 Feb 2026 01:11:20 +0000 From: Lexi Winter <ivy@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 34565dd970f6 - stable/15 - bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTER Message-ID: <699a57b8.3fd6c.2c409c64@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/15 has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=34565dd970f648020074af9abf6d960fa3a2e189 commit 34565dd970f648020074af9abf6d960fa3a2e189 Author: Lexi Winter <ivy@FreeBSD.org> AuthorDate: 2026-01-03 01:13:22 +0000 Commit: Lexi Winter <ivy@FreeBSD.org> CommitDate: 2026-02-22 00:49:46 +0000 bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTER Currently, we disallow BRDGSIFVLANSET when IFBRF_VLANFILTER is disabled. There's no particular reason to do this, and it causes some undesirable behaviour such as not being able to remove the tagged config on a member after disabling vlanfilter on the bridge. Remove the restriction so BRDGSIFVLANSET is always accepted. PR: 292019 MFC after: 1 week Reviewed by: zlei, p.mousavizadeh_protonmail.com Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D54435 (cherry picked from commit 2e92aeede85c8986bd6f4dde65d2ac2449eccf51) --- sys/net/if_bridge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c index d7911a348d87..ca15deddaf7d 100644 --- a/sys/net/if_bridge.c +++ b/sys/net/if_bridge.c @@ -1992,9 +1992,6 @@ bridge_ioctl_sifvlanset(struct bridge_softc *sc, void *arg) struct ifbif_vlan_req *req = arg; struct bridge_iflist *bif; - if ((sc->sc_flags & IFBRF_VLANFILTER) == 0) - return (EXTERROR(EINVAL, "VLAN filtering not enabled")); - bif = bridge_lookup_member(sc, req->bv_ifname); if (bif == NULL) return (EXTERROR(ENOENT, "Interface is not a bridge member"));home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?699a57b8.3fd6c.2c409c64>