Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Aug 2017 15:18:08 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 221755] [new port] graphics/tesseract-devel: Development version of tesseract ocr engine from github repository.
Message-ID:  <bug-221755-13-QTiuX2Io3w@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-221755-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-221755-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221755

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
           Assignee|freebsd-ports-bugs@FreeBSD. |tobik@freebsd.org
                   |org                         |
                 CC|                            |tobik@freebsd.org

--- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> ---
Hi,

thanks for your submission.  I have done a short review and found a
couple of issues.

This port appears to install files in the same location as
graphics/tesseract.  You might need to add (see [0])

CONFLICTS=3D      tesseract-[0-9]*

XPORTVERSION=3D   4.0.0a
...
XUSE_GITHUB=3D    yes
XGH_ACCOUNT=3D    ${PORTNAME}-ocr
XGH_TAGNAME=3D    1e3bf29

Since this is a development version (i.e. you use a commit between two
releases) follow the procedure in [1] instead to set
DISTVERSION{,SUFFIX,PREFIX} accordingly (you do not need to set
GH_TAGNAME in this case).  It's best to not invent our own version
numbers.  (This applies to your other submissions from bug #221756
and bug #221757 too.)

For commit 1e3bf29 this is=20

DISTVERSION=3D    4.00.00dev-620
DISTVERSIONSUFFIX=3D      -g1e3bf29c
...
USE_GITHUB=3D     yes
GH_ACCOUNT=3D     tesseract-ocr

XLICENSE=3D       APACHE20

Add

LICENSE_FILE=3D   ${WRKSRC}/COPYING

Xpost-patch:
X       @${REINPLACE_CMD} -e 's|-O2 -DNDEBUG|-O3 -DNDEBUG -march=3Dnative|'
${WRKSRC}/configure.ac

This looks wrong, why replace it with -O3 -march=3Dnative?  Ports should
not set their own optimization flags (see [2]) and should respect
CFLAGS, CXXFLAGS, ...

Xbin/ambiguous_words
Xbin/classifier_tester
Xbin/cntraining
Xbin/combine_lang_model
Xbin/combine_tessdata
Xbin/dawg2wordlist
Xbin/lstmeval
Xbin/lstmtraining
Xbin/mftraining
Xbin/set_unicharset_properties
Xbin/shapeclustering
Xbin/tesseract
Xbin/text2image
Xbin/unicharset_extractor
Xbin/wordlist2dawg

pkg-plist is wrong.  Some of these are not installed without TOOLS which
means the option is broken at the moment.

What happened to the man pages?  graphics/tesseract has them and I see
the sources for them in ${WRKSRC}/doc.  Can they be generated and
installed too?

[0]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/conflict=
s.html
[1]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile=
-distfiles.html#makefile-master_sites-github-ex5
[2]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-cfl=
ags.html

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221755-13-QTiuX2Io3w>