Date: Sat, 2 Jul 2005 23:52:37 +0000 (UTC) From: Marcel Moolenaar <marcel@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/ia64/ia64 db_interface.c src/sys/ia64/include db_machdep.h src/sys/ddb db_command.c ddb.h Message-ID: <200507022352.j62NqbYN029713@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
marcel 2005-07-02 23:52:37 UTC
FreeBSD src repository
Modified files:
sys/ia64/ia64 db_interface.c
sys/ia64/include db_machdep.h
sys/ddb db_command.c ddb.h
Log:
Implement functions calls from within DDB on ia64. On ia64 a function
pointer doesn't point to the first instruction of that function, but
rather to a descriptor. The descriptor has the address of the first
instruction, as well as the value of the global pointer. The symbol
table doesn't know anything about descriptors, so if you lookup the
name of a function you get the address of the first instruction. The
cast from the address, which is the result of the symbol lookup, to a
function pointer as is done in db_fncall is therefore invalid.
Abstract this detail behind the DB_CALL macro. By default DB_CALL is
defined as db_fncall_generic, which yields the old behaviour. On ia64
the macro is defined as db_fncall_ia64, in which a descriptor is
constructed to yield a valid function pointer.
While here, introduce DB_MAXARGS. DB_MAXARGS replaces the existing
(local) MAXARGS. The DB_MAXARGS macro can be defined by platforms to
create a convenient maximum. By default this will be the legacy 10.
On ia64 we define this macro to be 8, for 8 is the maximum number of
arguments that can be passed in registers. This avoids having to
implement spilling of arguments on the memory stack.
Approved by: re (dwhite)
Revision Changes Path
1.60 +24 -16 src/sys/ddb/db_command.c
1.39 +10 -0 src/sys/ddb/ddb.h
1.27 +20 -0 src/sys/ia64/ia64/db_interface.c
1.12 +4 -0 src/sys/ia64/include/db_machdep.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507022352.j62NqbYN029713>