Date: Wed, 20 Jun 2018 11:02:45 -0700 From: "Jonathan T. Looney" <jtl@freebsd.org> To: hackagadget@gmail.com Cc: Conrad Meyer <cem@freebsd.org>, Ian Lepore <ian@freebsd.org>, "Simon J. Gerraty" <sjg@juniper.net>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r335402 - head/sbin/veriexecctl Message-ID: <CADrOrmu=cQBNqU2_onT_s=pPhB0A546Nf9Sy5RcZzL0%2BAurpDQ@mail.gmail.com> In-Reply-To: <CAEm%2B2uVXQc7%2Bx6tmQyfeiU4rYKFMCcFZ2Q3_SHA1jf%2BOoHThfg@mail.gmail.com> References: <201806200108.w5K18sIR050132@repo.freebsd.org> <CAG6CVpV124ze%2BY6xX2ZFqbM%2B3hJNEJWR2qpnChpey=PmiW6qXg@mail.gmail.com> <96021.1529475664@kaos.jnpr.net> <CAJ5_RoBvwNH7-ZCd3LxtXg21TE49uX2y35Jwa6MM%2Bwn%2BX0_wUQ@mail.gmail.com> <17033.1529508519@kaos.jnpr.net> <CAG6CVpVwrWaDMcVRfgaOHagfPbnmULKe6R=GJiZi-reZYbZr8A@mail.gmail.com> <1529510299.24573.5.camel@freebsd.org> <CAG6CVpUgy8LhCkFZZ1D8BH%2BqJ_CDikvYNJrM9Nc0Ut5u=AVMHA@mail.gmail.com> <CAEm%2B2uVXQc7%2Bx6tmQyfeiU4rYKFMCcFZ2Q3_SHA1jf%2BOoHThfg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 20, 2018 at 9:49 AM Stephen Kiernan <hackagadget@gmail.com> wrote: > And I was working on those sets of changes, when work and family didn't > steal away time. I was told that some discussion happened at BSDCan this > year in such that veriexec should go in as-is so it would be there, which is why > the commit happened (given the review was approved to land back in January.) I will readily admit that I was probably the source of this. My reasoning was fairly simple: when a review has been open for over a year with no action, it seems like the submitter should be able to commit it without waiting for more review, if they are confident in their change. I stand by that (and, in fact, would substitute something shorter for "over a year"). (Of course, if the submitter has other reasons for delaying the commit, that's their prerogative, and I wasn't intending to push Steve to commit this before he was ready.) Jonathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADrOrmu=cQBNqU2_onT_s=pPhB0A546Nf9Sy5RcZzL0%2BAurpDQ>