Date: Tue, 30 Sep 2025 10:53:45 +0200 From: Matthias Andree <mandree@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Yuri Pankov <yuri@FreeBSD.org> Subject: Re: git: fd46b8c7f0d7 - main - filesystems/libblkid: fix odd reads and fdisk Message-ID: <fab6c583-a6ca-487f-82b7-e9f77b47f4e3@freebsd.org> In-Reply-To: <CALH631=f-joG3rbXv4Boqu3c4afwYSVga8RgFJkrB8A0OFchhw@mail.gmail.com> References: <202509292349.58TNnTJK061493@gitrepo.freebsd.org> <CALH631=f-joG3rbXv4Boqu3c4afwYSVga8RgFJkrB8A0OFchhw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
Am 30.09.25 um 08:44 schrieb Gleb Popov: > On Tue, Sep 30, 2025 at 2:49 AM Matthias Andree <mandree@freebsd.org> wrote: >> >> The branch main has been updated by mandree: >> >> Could the port maintainer please check with the upstream what their >> stance on supporting non-GNU userspaces and non-Linux kernels is? >> Can we work with them to get such fixes upstreamed or will they turn >> us down because the tools are specifically called "util-linux"? > > All right, I'll put this into my TODO, but no ETA, unfortunately. > Thanks for digging this out anyways. Hmmm... ok, they seem to have this clause in their Documentation/howto-contribute.txt: [1] > Various Notes > [...] > * patches relying on kernel features that are not in Linus Torvalds's > tree are not accepted. [1] <https://github.com/util-linux/util-linux/blob/master/Documentation/howto-contribute.txt>; I would guess the FreeBSD kernel isn't in Linus Torvalds's tree... so talking about the S_ISCHR() vs. S_ISBLK() changes I wonder if they would accept a refactoring patch that centralized that "is this device acceptable" check in once function and/or macro... They have more or less copied those checks around to some places and having one clear blkid_validate_block_device() or similar might be acceptable and then we'd have to patch only one place for that purpose. -- Matthias Andree FreeBSD ports committerhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fab6c583-a6ca-487f-82b7-e9f77b47f4e3>