Date: Thu, 16 Jul 2015 22:14:25 -0600 From: Warner Losh <imp@bsdimp.com> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: Zbigniew Bodek <zbb@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r285627 - in head/sys: arm/arm arm/at91 arm/cavium/cns11xx arm/samsung/s3c2xx0 arm/xscale/i80321 arm/xscale/i8134x arm/xscale/ixp425 arm/xscale/pxa arm64/arm64 ddb i386/i386 powerpc/boo... Message-ID: <1F072A78-AD5E-4597-B064-C51790AF2F12@bsdimp.com> In-Reply-To: <CAJ5_RoBkD0O3KzUoTaim20Vk7gkmKOAoDmmipmYNd23JmS5kbg@mail.gmail.com> References: <201507161046.t6GAkrEt028784@repo.freebsd.org> <CAJ5_RoBkD0O3KzUoTaim20Vk7gkmKOAoDmmipmYNd23JmS5kbg@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Jul 16, 2015, at 12:02 PM, Benjamin Kaduk <bjkfbsd@gmail.com> wrote: > > On Thu, Jul 16, 2015 at 6:46 AM, Zbigniew Bodek <zbb@freebsd.org> wrote: > Author: zbb > Date: Thu Jul 16 10:46:52 2015 > New Revision: 285627 > URL: https://svnweb.freebsd.org/changeset/base/285627 > > Log: > Fix KSTACK_PAGES issue when the default value was changed in KERNCONF > > If KSTACK_PAGES was changed to anything alse than the default, > the value from param.h was taken instead in some places and > the value from KENRCONF in some others. This resulted in > inconsistency which caused corruption in SMP envorinment. > > Ensure all places where KSTACK_PAGES are used the opt_kstack_pages.h > is included. > > This leads to the question: why is KSTACK_PAGES defined in param.h at all, if the value will be incorrect for custom kernel configurations? It is a work around for the Cavium arm64 kernel. It may or may not be needed in the fullness of time, but for now it’s needed to make progress on the port. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVqIEiAAoJEGwc0Sh9sBEAo5cQALR9RiitwRkMCDMvdPiOl6jt aeVsRtzhe3vYX1gxaBItwbEMsqUuzd5yHMhRQGTP8IS4rTn7FjB/9h3KB47ZbC62 1k3lnCgOvWjFLvhUYrenrFtXnCg/IYIIR0X5Lv6XdSxiNM2uOp72FaN45/SZSJNe bIFHUyvr/kQzIhdh9G7Nqc47djIgZXQ1+cYRXhszKKRnE1L6yBLK3O7Lw7SV0qXF +9+e59T6513EVXfquOU0OR4l47SCxCBGTYb/VE85lHut4kJtlRgYuY5MoNJc/Fwl GMobmW3MoRtwrb1UEuSUsnoEb3Rk48f07ciR0hCde8qa4visfkvRHFJ6scyGJbYp Mb0rZi1fQvzuKnLjFqpJgKXzAbWzY/LRic9wOY7gzE98B7UKd9k6sep0n/rigS42 vF/SfcCJLQlmc/Kpd9KOCDq7UPV0vJzjrZIb0uOx5MaaWd/rxWb8vgRVcyCpeogl X1B50WReHQSMw9dWkVXCU9hC39QB3PR9wHcFE1Pi3LZeyLnJgmkGkzyVIuVjtE1r hlWmyyF0jolYR73vbnfljpcBu6Fsn1XvfkY+yp7o6Yxdufr7EIlUiBFP8OQ0SqMv v9/fL/52XzWz4rhzy3zsmDEsQFS08xgylPBh81+fELYg7P5zwEjF/aYYFLEJzq/4 92bc4Q6dLdNZpWvqlrq6 =hcHy -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1F072A78-AD5E-4597-B064-C51790AF2F12>