Date: Mon, 6 Sep 1999 14:10:02 -0700 (PDT) From: Parag Patel <parag@cgt.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/13546: Too-verbose output from PCI probe at bootup Message-ID: <199909062110.OAA72703@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/13546; it has been noted by GNATS. From: Parag Patel <parag@cgt.com> To: freebsd-gnats-submit@freebsd.org Cc: Subject: Re: kern/13546: Too-verbose output from PCI probe at bootup Date: Mon, 06 Sep 1999 14:08:03 -0700 Following up to my easlier bug-report (kern/13546), I looked over the PCI code in STABLE and CURRENT more closely. The CURRENT code does not display this messaage because the code is no longer there! CURRENT probes for and attaches PCI bridges as bus/devices and STABLE does not. In pci/pci.c, the STABLE version uses the "bushigh" return value from pci_probebus() to determine the next PCI bus number to probe. My guess is that the 4xPPRO box I've got lies and always returns one more bus to probe for this code. CURRENT's pci/pci.c however doesn't use this "bushigh" information from pci_add_children(), and indeed doesn't use its return value at all. (The code determining bushigh can be deleted and pci_add_children should return "void".) It seems to detect the bridge chip and attach that as a device and then probes under it. STABLE doesn't seem to do this and its code is scattered with XXX througout. So I think my earlier patch for simply wrapping the "Probing PCI bus" message with an "if (bootverbose)" is the right solution/workaround for systems like mine. Not that it's a big deal - it's easy enough for me to patch by hand - but I thought that others may be similarly afflicted. -- Parag Patel To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909062110.OAA72703>