Date: Tue, 26 Feb 2013 11:43:12 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: Christoph Mallon <christoph.mallon@gmx.de>, freebsd-arch@FreeBSD.org Subject: Re: Large Capsicum patch for review. Message-ID: <867glvbbjz.fsf@ds4.des.no> In-Reply-To: <20130225215004.GA1375@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Mon, 25 Feb 2013 22:50:05 %2B0100") References: <20130213025547.GA2025@garage.freebsd.pl> <20130213230221.GB1375@garage.freebsd.pl> <20130223221116.GR1377@garage.freebsd.pl> <5129ADC5.5040306@gmx.de> <512A2CA0.2050509@gmx.de> <20130224235936.GX1377@garage.freebsd.pl> <512B3DBB.4080909@gmx.de> <20130225215004.GA1375@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
Pawel Jakub Dawidek <pjd@FreeBSD.org> writes: > I use size_t as this is preferred type for size, but I don't need size_t > for iterator, because I know the value will never need more than 16 > bits, so I use int as a more CPU-friendly type. Using int as an iterator can lead to warnings about signedness mismatch in loop conditions etc., so you should at the very least use unsigned int. Besides, size_t is equal to unsigned long on all platforms, so "CPU-friendly" is not a valid argument. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867glvbbjz.fsf>