Date: Mon, 24 Aug 1998 20:40:09 +0200 From: Stefan Eggers <seggers@semyam.dinoco.de> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: Kris Kennaway <kkennawa@physics.adelaide.edu.au>, Mike Smith <mike@smith.net.au>, freebsd-current@FreeBSD.ORG, seggers@semyam.dinoco.de Subject: Re: lpr code cleanup? (was: Re: gcc 2.8 ) Message-ID: <199808241840.UAA25824@semyam.dinoco.de> In-Reply-To: Your message of "Sun, 23 Aug 1998 13:40:06 EDT." <199808231740.NAA23791@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> The intent of this was to make sure that anyone who introduced > warnings after I had laboriously eliminated them would get pounded on > by the -current regulars for breaking the build. I took a look at the code and CWARNFLAGS didn't get used in all of the makefiles so I fixed that in a local copy of the lpr source - and of course corrected the complaints egcs (which I used for the test as it seems to be a little bit more picky than the system's gcc) gave me after doing that. In the course of doing this I found a misdeclared function. Nothing serious as it was the result type and the result wasn't used anyway. The "register varname;" definitions in some of the functions I changed to "register int varname;" which silenced egcs and is OK for K&R, too. Compiling now works for me with a recent egcs (a July snapshot) for the lpr subsystem. Don't know about the rest as I buildworld with gcc. I will now take a close look at my changes in the next few days, inte- grate it in my local source tree and then install the new executables. Maybe it still works afterward. ;-) Anybody interested in the changes I made can of course get a diff via email before I dare to send a PR. Stefan. -- Stefan Eggers Lu4 yao2 zhi1 ma3 li4, Max-Slevogt-Str. 1 ri4 jiu3 jian4 ren2 xin1. 51109 Koeln Federal Republic of Germany To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808241840.UAA25824>