Date: Thu, 14 Nov 2013 09:47:16 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Colin Percival <cperciva@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r258124 - head/usr.sbin/portsnap/portsnap Message-ID: <alpine.BSF.2.00.1311140945560.10113@fledge.watson.org> In-Reply-To: <201311140922.rAE9MW39043456@svn.freebsd.org> References: <201311140922.rAE9MW39043456@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Nov 2013, Colin Percival wrote: > Log: > When verifying that files we need are present, also check that they don't > have zero length. Filesystem corruption will tend to truncate files, and > since these are short that's likely to result in them becoming empty. > > Suggested by: Richard Clayton > Convinced by: rwatson > MFC after: 3 weeks I think I'd probably express this slightly differently: the filesystem isn't corrupted, it just doesn't contain the data you expect. As filesystems don't guarantee data is there until fsync() has returned, it is actually meeting all its promises -- e.g., vs corrupted inode contents due to a filesystem bug. Robert
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1311140945560.10113>