Date: Tue, 18 Nov 2025 18:04:18 +0100 From: Daniel Engberg <diizzy@FreeBSD.org> To: Gleb Popov <arrowd@freebsd.org> Cc: "Sergey A. Osokin" <osa@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b4a4910b55ef - main - dns/aardvark-dns: add new port Message-ID: <810750a7-e1cf-458e-a410-bcd7c5decf52@FreeBSD.org> In-Reply-To: <CALH631mOVJRp-a-xWsfvoitD-CNVFtg2s1ArJ8zAcwPO54zk0g@mail.gmail.com> References: <691c97fb.3da01.9e98319@gitrepo.freebsd.org> <e7d75cd5-bac8-40e4-b193-f22ec17b5c6e@FreeBSD.org> <CALH631mOVJRp-a-xWsfvoitD-CNVFtg2s1ArJ8zAcwPO54zk0g@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On 2025-11-18 17:49, Gleb Popov wrote: > On Tue, Nov 18, 2025 at 7:42 PM Daniel Engberg <diizzy@freebsd.org> wrote: >> Hi, >> >> This is looks not ideal? :-) >> Why is libinotify always pulled in as a dependency if it's in base? >> For consistency with the rest of the tree probably better to use >> OSVERSION or OSREL/OSREL:R instead of just checking that it exists. > > Checking for file existence is actually more consistent - other > inotify-sensitive ports are already doing that. > But I agree that LIB_DEPENDS should be under the condition too. My reasoning is for consistency and at least trying to keep the tree relatively tidy. Once versions goes EoL it's much easier to grep the tree for OSVERSION or OSREL (which people already do) than looking for various "random" file checks which aren't documented. Best regards, Danielhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?810750a7-e1cf-458e-a410-bcd7c5decf52>