Date: Fri, 5 Apr 2019 13:29:56 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Enji Cooper <yaneurabeya@gmail.com> Cc: rgrimes@freebsd.org, cem@freebsd.org, Ed Maste <emaste@freebsd.org>, Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs Message-ID: <201904052029.x35KTuCo041158@gndrsh.dnsmgr.net> In-Reply-To: <FAF85814-991B-4D30-96AD-2B3D46E4E97F@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 5, 2019, at 13:22, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
>
> >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste <emaste@freebsd.org> wrote:
> >>>
> >>>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
> >>>>
> >>>
> >>>>> +static const u_char dot_name[] = {
> >>>>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> >>>>> +static const u_char dotdot_name[] = {
> >>>>> + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> >>>>> +
> >>>
> >>> They are all either '.' or ' ', the commas are just list separators.
> >>> IMO spaces after the commas would make it slightly easier to see.
> >>
> >> Would it make sense to just use the normal string syntax for char
> >> array assignment?
> >>
> >> static const u_char dot_name[11] = ". ";
> >> static const u_char dotdot_name[11] = ".. ";
> >>
> >> Seems more clear to me.
> >
> > To try and end this thread, I already stated it was in review,
> > let me get a pointer to it, if you have comments please post
> > them there:
> > https://reviews.freebsd.org/D19829
>
> It would probably be a good idea to add a comment in the code to document the intention.
> Thanks,
Again, there is a review up, D19829, please comment there.
> -Enji
--
Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904052029.x35KTuCo041158>