Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Nov 2003 16:20:40 -0500 (EST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Peter Wemm <peter@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   RE: PERFORCE change 42350 for review
Message-ID:  <XFMail.20031114162040.jhb@FreeBSD.org>
In-Reply-To: <200311141846.hAEIkIap057379@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 14-Nov-2003 Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=42350
> 
> Change 42350 by peter@peter_overcee on 2003/11/14 10:46:16
> 
>       converge with -current a bit.  I dont know if jhb intends to commit this
>       change that I originally picked up via jhb_acpipci or not.

No, installnig atpic handlers by default is the better solution.

> Affected files ...
> 
> .. //depot/projects/hammer/sys/amd64/amd64/intr_machdep.c#9 edit
> 
> Differences ...
> 
> ==== //depot/projects/hammer/sys/amd64/amd64/intr_machdep.c#9 (text+ko) ====
> 
> @@ -106,7 +106,6 @@
>       }
>       intrcnt_register(isrc);
>       interrupt_sources[vector] = isrc;
> -     isrc->is_pic->pic_enable_intr(isrc);
>       mtx_unlock_spin(&intr_table_lock);
>       return (0);
>  }
> @@ -132,6 +131,7 @@
>           ithread_priority(flags), flags, cookiep);
>       if (error == 0) {
>               intrcnt_updatename(isrc);
> +             isrc->is_pic->pic_enable_intr(isrc);
>               isrc->is_pic->pic_enable_source(isrc);
>       }
>       return (error);

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20031114162040.jhb>