Date: Thu, 14 Nov 2013 01:49:07 -0800 From: Colin Percival <cperciva@freebsd.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r258124 - head/usr.sbin/portsnap/portsnap Message-ID: <52849C93.5010500@freebsd.org> In-Reply-To: <alpine.BSF.2.00.1311140945560.10113@fledge.watson.org> References: <201311140922.rAE9MW39043456@svn.freebsd.org> <alpine.BSF.2.00.1311140945560.10113@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/14/13 01:47, Robert Watson wrote: > On Thu, 14 Nov 2013, Colin Percival wrote: >> When verifying that files we need are present, also check that they don't >> have zero length. Filesystem corruption will tend to truncate files, and >> since these are short that's likely to result in them becoming empty. > > I think I'd probably express this slightly differently: the filesystem isn't > corrupted, it just doesn't contain the data you expect. As filesystems don't > guarantee data is there until fsync() has returned, it is actually meeting all > its promises -- e.g., vs corrupted inode contents due to a filesystem bug. True, I should have written "crashes resulting in data loss". -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52849C93.5010500>