Date: Tue, 06 Dec 2016 14:01:43 -0800 From: John Baldwin <jhb@freebsd.org> To: Michal Meloun <mmel@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309531 - head/sys/arm/include Message-ID: <1802951.O895X1uuQH@ralph.baldwin.cx> In-Reply-To: <201612041527.uB4FRduc064051@repo.freebsd.org> References: <201612041527.uB4FRduc064051@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, December 04, 2016 03:27:39 PM Michal Meloun wrote: > Author: mmel > Date: Sun Dec 4 15:27:39 2016 > New Revision: 309531 > URL: https://svnweb.freebsd.org/changeset/base/309531 > > Log: > Implement fake pmap_mapdev_attr() for ARMv6. > This function is referenced, but never called from DRM2 code. Also, > real behavior of pmap_mapdev_attr() in ARM world is unclear as we don't > have any additional attribute for a device memory type. > > MFC after: 2 weeks One more question: why not define this in pmap.c instead of an inline function in the header file? (The inline bit seemed to have led to several followups due to build breakage and the "fixes" require a fair bit of header pollution.) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1802951.O895X1uuQH>