Date: Tue, 2 Mar 2021 20:41:32 +0200 From: Toomas Soome <tsoome@me.com> To: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net> Cc: rgrimes@freebsd.org, Jakob Alvermark <jakob@alvermark.net>, FreeBSD Developers <developers@freebsd.org>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: testers needed: loader: use display pixel density for font autoselection Message-ID: <FB23EA9A-5D3D-4C96-B639-8822B8542796@me.com> In-Reply-To: <202103021832.122IW831047925@gndrsh.dnsmgr.net> References: <202103021832.122IW831047925@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 2. Mar 2021, at 20:32, Rodney W. Grimes <freebsd-rwg@gndrsh.dnsmgr.net> wrote: > >>> On 26. Feb 2021, at 17:56, Rodney W. Grimes <freebsd-rwg@gndrsh.dnsmgr.net> wrote: >>> >>>>> On 26. Feb 2021, at 05:42, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote: >>>>> >>>>>>> On 23. Feb 2021, at 17:53, Jakob Alvermark <jakob@alvermark.net> wrote: >>>>>>> >>>>>>> On 2/23/21 12:27 PM, Toomas Soome via freebsd-current wrote: >>>>>>>> hi! >>>>>>>> >>>>>>>> I have done some work to make font pickup a bit smarter (hopefully better;), but my own ability to test is limited to one bugged supermicro and one MBP with retina display? >>>>>>>> >>>>>>>> The phab link ishttps://reviews.freebsd.org/D28849 <https://reviews.freebsd.org/D28849>; >>>>>>>> >>>>>>>> I have built loader binaries as well (bios and uefi): >>>>>>>> loader_lua<http://148-52-235-80.sta.estpak.ee/loader_lua>; >>>>>>>> loader_lua.efi<http://148-52-235-80.sta.estpak.ee/loader_lua.efi>; > > I have tested this on: > Lenovo W530 > Dell E5470 > Acer Aspire 1410 > > all work fine with resonable display resolution. > > One more comment below... > >>>>>>>> >>>>>>>> To test, you should remove screen.font= line from loader.conf and test with different resolutions. >>>>>>>> >>>>>>>> thanks, >>>>>>>> toomas >>>>>>> >>>>>>> >>>>>>> >>>>>>> Hi Toomas, >>>>>>> >>>>>>> >>>>>>> I tested on five different setups. >>>>>>> >>>>>>> Surface Pro 10.6"@1920x1080: >>>>>>> >>>>>>> The loader menu looks different, the "FreeBSD" text is on the right side of the screen. >>>>>> >>>>>> >>>>>> I think, this was the lua script bug we did fix not too long time ago. >>>>>> >>>>>>> >>>>>>> Otherwise, the font size is what I would call a normal size. >>>>>>> >>>>>>> >>>>>>> Acer laptop 11.6"@1366x768: >>>>>>> >>>>>>> Menu looks fine. Almost fills the entire screen. >>>>>>> >>>>>>> The font feels a little too big. >>>>>> >>>>>> >>>>>> The laptop built in displays usually do not give out EDID (we get physical dimensions from EDID), so there we fall back to try to get 80x25 terminal method. >>>>> >>>>> I am having a hard time with that statement. EDID is very common on laptop screens, infact I can not recall ever not seeing EDID on a laptops builtin screen. >>>>> My 11" acer 1400 has EDID in it. >>>>> >>>>> >>>> >>>> >>>> If there is EDID, then it is all good. I have seen cases we do not get it with available API. >>> >>> Is there a way for me to know if the laoder found EDID data or not? >>> It might be that the issue is that what ever loader is using for an API is not working. >>> I based my "EDID is very common on laptop screens" on the fact that X11 almost always finds EDID. >>> >> >> Yes, gop get / vbe list ? yes, it is inconsistent, should fix at some point? :) >> >> we do use gop get active edid/get discovered edid protocol and vbe function 0x4f15. > > On all my handy laptops, E5470, T400, W530, Acer 1410 edid is present and seen > by the loader. > > Thank You! rgds, toomas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FB23EA9A-5D3D-4C96-B639-8822B8542796>