Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 09 Apr 2026 11:28:45 +0200
From:      Kristof Provost <kp@FreeBSD.org>
To:        Andrew Turner <andrew@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 0ddaa4c86d68 - main - arm64: Add arm64 SVE tests
Message-ID:  <40C898CE-AE76-4421-AFC9-DBF05FEDE74C@FreeBSD.org>
In-Reply-To: <69d6645c.3d421.446b1290@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On 8 Apr 2026, at 16:21, Andrew Turner wrote:
> The branch main has been updated by andrew:
>
> URL: 
> https://cgit.FreeBSD.org/src/commit/?id=0ddaa4c86d68e8dacee8a78877e5742d53c122b3
>
> commit 0ddaa4c86d68e8dacee8a78877e5742d53c122b3
> Author:     Andrew Turner <andrew@FreeBSD.org>
> AuthorDate: 2026-04-08 14:17:55 +0000
> Commit:     Andrew Turner <andrew@FreeBSD.org>
> CommitDate: 2026-04-08 14:20:52 +0000
>
>     arm64: Add arm64 SVE tests
>
>     Add the tests/sys/arch directory for architecture-specific tests 
> and
>     use it to add arm64 SVE tests. These test the kernel is managing 
> the
>     SVE state in a way we expect.
>
>     These tests require SVE hardware support to run so will skip when 
> they
>     can't detect it.
>
>     Reviewed by:    markj
>     Sponsored by:   Arm Ltd
>     Differential Revision:  https://reviews.freebsd.org/D43311

This causes the tests to fail to run for me:

	kyua: E: Load of '/usr/tests/Kyuafile' failed: Failed to load Lua file 
'/usr/tests/Kyuafile': /usr/tests/Kyuafile:48: Load of 
'/usr/tests/sys/Kyuafile' failed: Failed to load Lua file 
'/usr/tests/sys/Kyuafile': /usr/tests/sys/Kyuafile:9: Load of 
'/usr/tests/sys/arch/Kyuafile' failed: File 
'/usr/tests/sys/arch/Kyuafile' not found.

I believe it needs this:

	diff --git a/tests/sys/arch/Makefile b/tests/sys/arch/Makefile
	index e1a35422410e..f83329c1dd43 100644
	--- a/tests/sys/arch/Makefile
	+++ b/tests/sys/arch/Makefile
	@@ -1,5 +1,9 @@
	+.include <src.opts.mk>
	+
	+TESTSDIR=              ${TESTSBASE}/sys/arch
	+
	 .if exists(${.CURDIR}/${MACHINE_ARCH})
	-SUBDIR+=       ${MACHINE_ARCH}
	+TESTS_SUBDIRS+=        ${MACHINE_ARCH}
	 .endif

	-.include <bsd.subdir.mk>
	+.include <bsd.test.mk>

Best regards,
Kristof
[-- Attachment #2 --]
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8">
</head>
<body><div style="font-family: sans-serif;"><div class="markdown" style="white-space: normal;">
<p dir="auto">On 8 Apr 2026, at 16:21, Andrew Turner wrote:</p>
<blockquote style="margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136BCE; color: #136BCE;">
<p dir="auto">The branch main has been updated by andrew:</p>
<p dir="auto">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=0ddaa4c86d68e8dacee8a78877e5742d53c122b3">https://cgit.FreeBSD.org/src/commit/?id=0ddaa4c86d68e8dacee8a78877e5742d53c122b3</a></p>;
<p dir="auto">commit 0ddaa4c86d68e8dacee8a78877e5742d53c122b3<br>
Author:     Andrew Turner <a href="mailto:andrew@FreeBSD.org">andrew@FreeBSD.org</a><br>
AuthorDate: 2026-04-08 14:17:55 +0000<br>
Commit:     Andrew Turner <a href="mailto:andrew@FreeBSD.org">andrew@FreeBSD.org</a><br>
CommitDate: 2026-04-08 14:20:52 +0000</p>
<pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">arm64: Add arm64 SVE tests

Add the tests/sys/arch directory for architecture-specific tests and
use it to add arm64 SVE tests. These test the kernel is managing the
SVE state in a way we expect.

These tests require SVE hardware support to run so will skip when they
can't detect it.

Reviewed by:    markj
Sponsored by:   Arm Ltd
Differential Revision:  https://reviews.freebsd.org/D43311
</code></pre>
</blockquote>
<p dir="auto">This causes the tests to fail to run for me:</p>
<pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">kyua: E: Load of '/usr/tests/Kyuafile' failed: Failed to load Lua file '/usr/tests/Kyuafile': /usr/tests/Kyuafile:48: Load of '/usr/tests/sys/Kyuafile' failed: Failed to load Lua file '/usr/tests/sys/Kyuafile': /usr/tests/sys/Kyuafile:9: Load of '/usr/tests/sys/arch/Kyuafile' failed: File '/usr/tests/sys/arch/Kyuafile' not found.
</code></pre>
<p dir="auto">I believe it needs this:</p>
<pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">diff --git a/tests/sys/arch/Makefile b/tests/sys/arch/Makefile
index e1a35422410e..f83329c1dd43 100644
--- a/tests/sys/arch/Makefile
+++ b/tests/sys/arch/Makefile
@@ -1,5 +1,9 @@
+.include &lt;src.opts.mk&gt;
+
+TESTSDIR=              ${TESTSBASE}/sys/arch
+
 .if exists(${.CURDIR}/${MACHINE_ARCH})
-SUBDIR+=       ${MACHINE_ARCH}
+TESTS_SUBDIRS+=        ${MACHINE_ARCH}
 .endif

-.include &lt;bsd.subdir.mk&gt;
+.include &lt;bsd.test.mk&gt;
</code></pre>
<p dir="auto">Best regards,<br>
Kristof</p>

</div>
</div>
</body>

</html>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40C898CE-AE76-4421-AFC9-DBF05FEDE74C>