Date: Fri, 11 Jul 2003 07:13:21 -0700 (PDT) From: Maxime Henrion <mux@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.sbin/rarpd Makefile rarpd.c Message-ID: <200307111413.h6BEDM1b034388@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
mux 2003/07/11 07:13:21 PDT
FreeBSD src repository
Modified files:
usr.sbin/rarpd Makefile rarpd.c
Log:
Huge cleanup of the rarpd(8) code :
- Use getifaddrs() instead of rolling our own buggy one. Previously,
rarpd(8) would fail to see some interfaces because of a hardcoded limit.
It now successfully sees any interface in the system, and this also makes
the code _much_ simpler.
- Replace strncpy() calls with strlcpy() calls. Some uses of strncpy()
were bogus ; the code wasn't ensuring that the string was NUL terminated.
- Don't try to guard about select() FD_* macros being undefined.
- Use IF_NAMESIZE and ETHER_ADDR_LEN macros where appropriate.
- Add static keywords to function definitions for consistency, since
the prototypes have it (I wonder why GCC didn't complain about this).
- Remove compat code for very old BSD versions and SunOS.
- Remove code for systems not having the dirent.h header.
- The code is now WARNS=5 clean so mark it as such.
- Don't add -DTFTP_DIR="/tftpboot" to the build command line since it's
the default.
MFC after: 2 weeks
Revision Changes Path
1.13 +2 -3 src/usr.sbin/rarpd/Makefile
1.36 +51 -186 src/usr.sbin/rarpd/rarpd.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200307111413.h6BEDM1b034388>