Date: Thu, 23 May 2002 09:43:31 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern kern Message-ID: <XFMail.20020523094331.jhb@FreeBSD.org> In-Reply-To: <20020523171421.L12695-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23-May-2002 Bruce Evans wrote: > On Wed, 22 May 2002, John Baldwin wrote: > >> jhb 2002/05/22 13:32:39 PDT >> >> Modified files: >> sys/i386/include cpufunc.h >> sys/kern kern_mutex.c >> Log: >> Rename pause() to ia32_pause() so it doesn't conflict with the pause() >> function defined in <unistd.h>. I didn't #ifdef _KERNEL it because the >> mutex implementation in libpthread will probably need this. > > This shoots the messenger. The main bug is gross namespace pollution in > <vgl.h>: > > %%% >#ifndef _VGL_H_ >#define _VGL_H_ > >#include <stdlib.h> >#include <unistd.h> >#include <string.h> >#include <machine/cpufunc.h> > %%% > > <machine/cpufunc.h> is really a kernel-only header, but it sometimes gets > abused in userland. I think this shouldn't be supported. It contains > mostly very machine-dependent interfaces, so it should be used in at most > the implementation of libvgl. libvgl uses i386 interfaces unconditionally, > so it only works on i386's, but this limitation is not documented. > > Bruce Well, I can see libpthread wanting to use this type of stuff, but that will also be a special case and will hopefully not conflict. (libpthread is going to want its own lock implementations that don't have to enter the kernel.) I don't mind renaming ia32_pause() back to pause() if someone wants to clean up libvgl. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020523094331.jhb>