Date: Mon, 03 Mar 2014 07:41:09 -0700 From: Ian Lepore <ian@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r262696 - head/sys/arm/arm Message-ID: <1393857669.1149.281.camel@revolution.hippie.lan> In-Reply-To: <20140303181837.I859@besplex.bde.org> References: <201403022125.s22LPXgd078485@svn.freebsd.org> <20140303181837.I859@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2014-03-03 at 18:49 +1100, Bruce Evans wrote: > On Sun, 2 Mar 2014, Ian Lepore wrote: > > > Log: > > Add __attribute__((used)) so that the delay implementation doesn't get > > optimized away as unreferenced, causing linker errors when trying to > > resolve the weak reference to the missing function. > > Why not use the standard FreeBSD macro __used? Hard-coded > __attribute__(())s are not only unportable; they are gross style bugs. > They were all replaced by FreeBSD macros in old versions of FreeBSD. Thanks. I actually looked for __used and somehow failed to find it. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1393857669.1149.281.camel>