Date: Fri, 14 Dec 2001 19:06:17 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Mark Murray <mark@grondar.za> Cc: Luigi Rizzo <luigi@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011214190617.A7887@sunbay.com> In-Reply-To: <200112141659.fBEGx9U02211@grimreaper.grondar.org> References: <20011214184532.A99179@sunbay.com> <200112141659.fBEGx9U02211@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 14, 2001 at 04:59:08PM +0000, Mark Murray wrote:
> > Now everybody knows that you don't actually use -CURRENT. :-)
> > In -CURRENT, main() doesn't require a prototype.
> > Please back these out.
>
> This is incorrect. I'm doing a big WARNS=2 sweep in usr.bin, and
> main _does_ need proper prototyping.
>
> This is not a proper prototype:
>
> int main();
>
> This is ok:
>
> int main(int, char **);
>
> and so is this (yeah, yeah, I know it is complete function):
>
> int
> main(int argc, char *argv[])
> {
> :
> }
>
> but NOT this
>
> int
> main()
> {
> :
> }
>
Mark, we are talking about the different thing here.
Recall the breakage when -Wmissing-prototype was put to WARNS?
The solution was added by David O'Brien in:
contrib/gcc.295/c-decl.c,v 1.4.
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011214190617.A7887>