Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Dec 2024 04:50:31 -0800
From:      David Wolfskill <david@catwhisker.org>
To:        Warner Losh <imp@freebsd.org>
Cc:        "Herbert J. Skuhra" <herbert@gojira.at>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 42ee30f19cc7 - main - depend-cleanup.sh: Need to  delete jemalloc.3 in objtree
Message-ID:  <Z11_F1xahbFJh4UO@albert.catwhisker.org>
In-Reply-To: <87y10icwq0.wl-herbert@gojira.at>
References:  <202412132304.4BDN4QSd029112@gitrepo.freebsd.org> <87y10icwq0.wl-herbert@gojira.at>

next in thread | previous in thread | raw e-mail | index | archive | help

--78wWDnwD/iYnl64s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 14, 2024 at 12:47:35PM +0100, Herbert J. Skuhra wrote:
> On Sat, 14 Dec 2024 00:04:26 +0100, Warner Losh wrote:
> >=20
> > The branch main has been updated by imp:
> >=20
> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D42ee30f19cc7ad85187cbf97=
155dbd5207a04845
> >=20
> > commit 42ee30f19cc7ad85187cbf97155dbd5207a04845
> > Author:     Warner Losh <imp@FreeBSD.org>
> > AuthorDate: 2024-12-13 17:46:59 +0000
> > Commit:     Warner Losh <imp@FreeBSD.org>
> > CommitDate: 2024-12-13 23:04:34 +0000
> >=20
> >     depend-cleanup.sh: Need to delete jemalloc.3 in objtree
> > ...    =20

> Does this actually work? Should this be
>=20
> if [ -h "$OBJTOP"/lib/libc/jemalloc.3 ]; then
>=20
> ?

Empirically:
On a system running:
FreeBSD 15.0-CURRENT #61 main-n274188-38cb1ba8637d: Fri Dec 13 11:58:34 UTC=
 2024     root@freebeast.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/=
sys/GENERIC amd64 1500029 1500029

after updating sources to main-n274215-da5aed38d80a and starting an
in-place source upgrade using meta mode, the build failed:

=2E..
Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/mail/mail
Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/tftp/tftp.1.gz
make[4]: don't know how to make jemalloc.3. Stop

make[4]: stopped making "all" in /usr/src/lib/libc
=2EERROR_TARGET=3D'jemalloc.3'
=2EERROR_META_FILE=3D''
=2EMAKE.LEVEL=3D'4'
MAKEFILE=3D''
=2EMAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes =
verbose'
_ERROR_CMD=3D'.PHONY'
=2E...

I then used "find" to find any ocurrences of "jemalloc.3" in
/usr/obj/; one was found: a symlink named
/usr/obj/usr/src/amd64.amd64/lib/libc/jemalloc.3, which pointed to
/usr/src/contrib/jemalloc/doc/jemalloc.3.

The latter did not exist.

Once I removed the symlink, the build succeeeded:
FreeBSD 15.0-CURRENT #62 main-n274215-da5aed38d80a: Sat Dec 14 12:08:41 UTC=
 2024     root@freebeast.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/=
sys/GENERIC amd64 1500029 1500029

On a pair of other (slower) machines, I then had the opportunity to
remove the symlink before starting the build; those completed without
incident.

I believe a src/UPDATING entry would be sufficient to help folks
avoid the error condition.

Peace,
david
--=20
David H. Wolfskill                              david@catwhisker.org
Re. tariffs: https://en.wikipedia.org/wiki/Smoot%E2%80%93Hawley_Tariff_Act

See https://www.catwhisker.org/~david/publickey.gpg for my public key.

--78wWDnwD/iYnl64s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iNUEARYKAH0WIQSTLzOSbomIK53fjFliipiWhXYx5QUCZ11/F18UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0OTMy
RjMzOTI2RTg5ODgyQjlEREY4QzU5NjI4QTk4OTY4NTc2MzFFNQAKCRBiipiWhXYx
5UMiAQCUzoRUvqbmUj5G6yosU7mjO8ez4OkJCMhqJnOD05u1ogD+KAIXWRdCIpk6
Z9rPp7al59hd5NIuVqOme/cueAoRVwo=
=pMBL
-----END PGP SIGNATURE-----

--78wWDnwD/iYnl64s--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Z11_F1xahbFJh4UO>