Date: Mon, 18 Feb 2019 07:02:11 -0500 From: Charlie Li <ml+freebsd@vishwin.info> To: Dimitry Andric <dim@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, freebsd-toolchain@freebsd.org Subject: Re: svn commit: r341825 - in head: . contrib/compiler-rt contrib/compiler-rt/include/sanitizer contrib/compiler-rt/include/xray contrib/compiler-rt/lib/BlocksRuntime contrib/compiler-rt/lib/asan contri... Message-ID: <d2f8c1c4-57ad-3022-8b84-50681bd63379@vishwin.info> In-Reply-To: <D472A7CA-760D-4733-8E72-2B0D0F2C0B65@FreeBSD.org> References: <201812111905.wBBJ5Yfu053488@repo.freebsd.org> <e80319d3-1d52-6142-ef08-c58dfd27444e@vishwin.info> <D472A7CA-760D-4733-8E72-2B0D0F2C0B65@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--egkOvq0hTMDHcwrPVDhgPLZmyLOT8VBxJ
Content-Type: multipart/mixed; boundary="vIxjsFHhQHgQX4FC264IsbUsulYi78BqZ";
protected-headers="v1"
From: Charlie Li <ml+freebsd@vishwin.info>
To: Dimitry Andric <dim@FreeBSD.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
svn-src-head@freebsd.org, freebsd-toolchain@freebsd.org
Message-ID: <d2f8c1c4-57ad-3022-8b84-50681bd63379@vishwin.info>
Subject: Re: svn commit: r341825 - in head: . contrib/compiler-rt
contrib/compiler-rt/include/sanitizer contrib/compiler-rt/include/xray
contrib/compiler-rt/lib/BlocksRuntime contrib/compiler-rt/lib/asan contri...
References: <201812111905.wBBJ5Yfu053488@repo.freebsd.org>
<e80319d3-1d52-6142-ef08-c58dfd27444e@vishwin.info>
<D472A7CA-760D-4733-8E72-2B0D0F2C0B65@FreeBSD.org>
In-Reply-To: <D472A7CA-760D-4733-8E72-2B0D0F2C0B65@FreeBSD.org>
--vIxjsFHhQHgQX4FC264IsbUsulYi78BqZ
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB-large
Content-Transfer-Encoding: quoted-printable
On 18/02/2019 06:49, Dimitry Andric wrote:
> On 18 Feb 2019, at 12:40, Charlie Li via freebsd-toolchain wrote:
>>
>> On 11/12/2018 14:05, Dimitry Andric wrote:
>>> head/contrib/libc++/include/type_traits
>>>
>> The change to the above named file breaks building any C++ code
>> containing _Float16 with devel/llvm80-8.0.0.r2 (and probably later, bu=
t
>> not 8.0.0.r1 or any earlier LLVM) on head (but not
>> projects/clang800-import, obviously). Example error, from our own copy=
>> of LLVM libunwind:
>>
>> --- libunwind.o ---
>> In file included from
>> /usr/src/contrib/llvm/projects/libunwind/src/libunwind.cpp:18:
>> In file included from
>> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/new:91:
>> In file included from
>> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/exception:83:
>> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/type_traits:740:56=
:
>> error: _Float16 is not supported on this target
>> template <> struct __libcpp_is_floating_point<_Float16> :
>> public true_type {};
>> ^
>> 1 error generated.
>> *** [libunwind.o] Error code 1
>=20
> Hm, which target did you compile for? I have run multiple universe
> builds, so I thought I had covered all possible targets. Or are you
> building with gcc?
>=20
Building head using xtoolchain-llvm80 on amd64, for amd64. Interestingly
didn't error when cross-building for aarch64.
The projects/clang800-import branch already has the bit in question
reverted, so is a moot point there.
--=20
Charlie Li
Can't think of a witty .sigline today=E2=80=A6
(This email address is for mailing list use; replace local-part with
vishwin for off-list communication if possible)
--vIxjsFHhQHgQX4FC264IsbUsulYi78BqZ--
--egkOvq0hTMDHcwrPVDhgPLZmyLOT8VBxJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE/3/Cqr5a+41PbEb+jnB43vIDq2wFAlxqnsMACgkQjnB43vID
q2yPcw/9HYsFnCBac7vX/Un9Co2E5cXVz11fma339t6bi6TPfSJvuE57rbiKoWwA
J+A2pTjFsDFH4epmpeNcdbGDXs96vyYvipGKvA/i+zfqvsHJW/U3ypukpgIZoHMQ
gLQ467P+mc1RXii1iqGf2Ypu9M1ZFiRwbx4gDZ2JkZjyOhx/ebyCw+nBoONy7yCi
hTYj0Vy9+ES9ZBnrM7a7zFQMEzX1ZZqUx+/nsVIdOLHBge8kau8/yO6mSJxm0adq
IrKwdauvKdyvZoRKPvXP9nHqtmugo93sNCYqGsH2AWpUspxVlHP9L7X0uLo9JXJ5
25i/uZcR51evXJsCRgsmq6gfgZQN1I6YV0XH+Xg4B3tNMBwNJUuqrjhfd+5ggUR2
HZhi9RU7T+Utrsn52rr39Luzmpf5timyt/09p8TlR6qN0gkr0HaWRSOiCApD05oU
qrcyvEcCpVJpUpsZ6DVTr6hFqCwYxoWW784SmX53bopx7qhlvhIUyMLQLMo/53VH
r6rrjAx3IY1B46vYLUSg6aTLSZC+5j+uZc9GfuUinu9CTdZ4GfRsirQ1q0bICsSF
ZrRaj9dJ0sPi70diSTl8KtFfk/P6BdV1BCC7J3Ac1TzJyhJvgjFCpHRxBoYBeM0t
/22GrSTfwTxZvKaKq1I9PqXtyoDolxgjHeSU534eURZE9pT3A8E=
=3W4s
-----END PGP SIGNATURE-----
--egkOvq0hTMDHcwrPVDhgPLZmyLOT8VBxJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d2f8c1c4-57ad-3022-8b84-50681bd63379>