Date: Mon, 21 May 2001 22:01:07 -0700 (PDT) From: Matt Dillon <dillon@earth.backplane.com> To: John Baldwin <jhb@FreeBSD.org> Cc: "Brian F. Feldman" <green@FreeBSD.org>, hackers@FreeBSD.org Subject: Re: RE: vmspace leak (+ tentative fix) Message-ID: <200105220501.f4M517P12040@earth.backplane.com> References: <XFMail.010521124613.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:Ok, then why not let the current shmexit() stay in exit1() as a hack to help :free memory, but add in a check in vmspace_free() as well to catch any race :conditions that may fall through the cracks? As long as we clear the shm :pointer in struct vmspace when we free it then we won't be double free'ing, and :will always free it eventually. That is also a much simpler change. :) :Additionally, adding to the comment in exit1() clarifying that this is an :attempt to free resources as soon as possible and that the race condition is :known and that vmspace_free() is a catch-all might be nice as well. : :-- : :John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ :PGP Key: http://www.baldwin.cx/~john/pgpkey.asc It's not really good programming practice. Someone might trip over it later on. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105220501.f4M517P12040>