Date: Fri, 21 Dec 2018 16:20:13 +0000 (UTC) From: Andrew Rybchenko <arybchik@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r342332 - stable/12/sys/dev/sfxge/common Message-ID: <201812211620.wBLGKDcW074806@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: arybchik Date: Fri Dec 21 16:20:13 2018 New Revision: 342332 URL: https://svnweb.freebsd.org/changeset/base/342332 Log: MFC r341197 sfxge(4): fix comparison always true warning Loopback type used as bit index has efx_loopback_type_t type which is enum. clang complains that it is always true when it is compared with qword (64 bit) bits number boundary. Sponsored by: Solarflare Communications, Inc. Differential Revision: https://reviews.freebsd.org/D18228 Modified: stable/12/sys/dev/sfxge/common/efx_port.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/sfxge/common/efx_port.c ============================================================================== --- stable/12/sys/dev/sfxge/common/efx_port.c Fri Dec 21 16:13:48 2018 (r342331) +++ stable/12/sys/dev/sfxge/common/efx_port.c Fri Dec 21 16:20:13 2018 (r342332) @@ -149,7 +149,7 @@ efx_port_loopback_set( EFSYS_ASSERT(link_mode < EFX_LINK_NMODES); if (EFX_TEST_QWORD_BIT(encp->enc_loopback_types[link_mode], - loopback_type) == 0) { + (int)loopback_type) == 0) { rc = ENOTSUP; goto fail1; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812211620.wBLGKDcW074806>