Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Aug 2016 03:08:36 +0000
From:      Phabricator <phabric-noreply@FreeBSD.org>
To:        freebsd-net@freebsd.org
Subject:   [Differential] D7593: net/rndis: Add canonical RNDIS major/minor version as of today.
Message-ID:  <ced985e7d3a688ece1f5c81730200f5e@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-ukhjohui6ezrkecptveh-req@FreeBSD.org>
References:  <differential-rev-PHID-DREV-ukhjohui6ezrkecptveh-req@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
This revision was automatically updated to reflect the committed changes.
Closed by commit rS304722: net/rndis: Add canonical RNDIS major/minor version as of today. (authored by sephe).

CHANGED PRIOR TO COMMIT
  https://reviews.freebsd.org/D7593?vs=19530&id=19604#toc

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST UPDATE
  https://reviews.freebsd.org/D7593?vs=19530&id=19604

REVISION DETAIL
  https://reviews.freebsd.org/D7593

AFFECTED FILES
  head/sys/dev/usb/net/if_urndis.c
  head/sys/net/rndis.h

CHANGE DETAILS

diff --git a/head/sys/net/rndis.h b/head/sys/net/rndis.h
--- a/head/sys/net/rndis.h
+++ b/head/sys/net/rndis.h
@@ -23,6 +23,10 @@
 #ifndef	_NET_RNDIS_H_
 #define	_NET_RNDIS_H_
 
+/* Canonical major/minor version as of 22th Aug. 2016. */
+#define	RNDIS_VERSION_MAJOR		0x00000001
+#define	RNDIS_VERSION_MINOR		0x00000000
+
 #define	RNDIS_STATUS_BUFFER_OVERFLOW 	0x80000005L
 #define	RNDIS_STATUS_FAILURE 		0xC0000001L
 #define	RNDIS_STATUS_INVALID_DATA 	0xC0010015L
diff --git a/head/sys/dev/usb/net/if_urndis.c b/head/sys/dev/usb/net/if_urndis.c
--- a/head/sys/dev/usb/net/if_urndis.c
+++ b/head/sys/dev/usb/net/if_urndis.c
@@ -658,7 +658,7 @@
 	msg.rm_type = htole32(REMOTE_NDIS_INITIALIZE_MSG);
 	msg.rm_len = htole32(sizeof(msg));
 	msg.rm_rid = 0;
-	msg.rm_ver_major = htole32(1);
+	msg.rm_ver_major = htole32(RNDIS_VERSION_MAJOR);
 	msg.rm_ver_minor = htole32(1);
 	msg.rm_max_xfersz = htole32(RNDIS_RX_MAXLEN);
 



EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, glebius, bz, gnn, rwatson, hselasky
Cc: freebsd-net-list

[-- Attachment #2 --]
diff --git a/head/sys/net/rndis.h b/head/sys/net/rndis.h
--- a/head/sys/net/rndis.h
+++ b/head/sys/net/rndis.h
@@ -23,6 +23,10 @@
 #ifndef	_NET_RNDIS_H_
 #define	_NET_RNDIS_H_
 
+/* Canonical major/minor version as of 22th Aug. 2016. */
+#define	RNDIS_VERSION_MAJOR		0x00000001
+#define	RNDIS_VERSION_MINOR		0x00000000
+
 #define	RNDIS_STATUS_BUFFER_OVERFLOW 	0x80000005L
 #define	RNDIS_STATUS_FAILURE 		0xC0000001L
 #define	RNDIS_STATUS_INVALID_DATA 	0xC0010015L
diff --git a/head/sys/dev/usb/net/if_urndis.c b/head/sys/dev/usb/net/if_urndis.c
--- a/head/sys/dev/usb/net/if_urndis.c
+++ b/head/sys/dev/usb/net/if_urndis.c
@@ -658,7 +658,7 @@
 	msg.rm_type = htole32(REMOTE_NDIS_INITIALIZE_MSG);
 	msg.rm_len = htole32(sizeof(msg));
 	msg.rm_rid = 0;
-	msg.rm_ver_major = htole32(1);
+	msg.rm_ver_major = htole32(RNDIS_VERSION_MAJOR);
 	msg.rm_ver_minor = htole32(1);
 	msg.rm_max_xfersz = htole32(RNDIS_RX_MAXLEN);
 


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ced985e7d3a688ece1f5c81730200f5e>