Date: Fri, 13 Nov 2015 16:24:47 -0500 From: Randall Stewart <rrs@netflix.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: "Alexander V. Chernikov" <melifaro@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, imp@freebsd.org Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys Message-ID: <B554CD5E-6B2A-4E63-BB83-ECB267ABCB92@netflix.com> In-Reply-To: <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> <CCAE1243-3DC1-4077-BC55-AA6EA7750181@netflix.com> <56465003.8070709@FreeBSD.org> <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Looking at the patch, we need a define of your _callout_stop_safe and we need to switch callout_stop()=92s define to use the new _callout_stop_safe() R On Nov 13, 2015, at 4:20 PM, Randall Stewart <rrs@netflix.com> wrote: > No alexander=92s panic=92s are because the > LLREF > is done if (callout_stop()) >=20 > But now if it was not running -1 is returned.. >=20 > Try the patch I just sent.. >=20 > R > On Nov 13, 2015, at 4:02 PM, Bryan Drewery <bdrewery@FreeBSD.org> = wrote: >=20 >> On 11/13/2015 1:00 PM, Randall Stewart wrote: >>> Bryan: >>>=20 >>> This looks like a decent thing to do.. >>>=20 >>> Still wondering why changing the callout.h header file would not = have caused >>> things to recompile to pick up the new argument.. >>>=20 >>> We can do it this way though it looks fine. >>>=20 >>> You want to commit it or I? >>=20 >> Well your change is totally safe for compiling. It's just not KBI >> backwards compat for older modules. This is not typically a problem = but >> I think in this case it is worth doing to avoid random data coming = into >> the 'drain' argument if loading an older module. >>=20 >> I'll do a test build and commit it. Perhaps this is what was leading = to >> Alexander's panics. >>=20 >> I haven't analyzed the return value issue at all. >>=20 >>=20 >> --=20 >> Regards, >> Bryan Drewery >>=20 >=20 > -------- > Randall Stewart > rrs@netflix.com > 803-317-4952 >=20 >=20 >=20 >=20 >=20 -------- Randall Stewart rrs@netflix.com 803-317-4952
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B554CD5E-6B2A-4E63-BB83-ECB267ABCB92>