Date: Fri, 27 Feb 2009 13:31:37 -0800 From: Sam Leffler <sam@freebsd.org> To: Andrew Thompson <thompsa@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189123 - head/sys/dev/usb/wlan Message-ID: <49A85BB9.4080304@freebsd.org> In-Reply-To: <200902272114.n1RLETGJ083343@svn.freebsd.org> References: <200902272114.n1RLETGJ083343@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrew Thompson wrote: > Author: thompsa > Date: Fri Feb 27 21:14:29 2009 > New Revision: 189123 > URL: http://svn.freebsd.org/changeset/base/189123 > > Log: > Partial sync to //depot/projects/usb > > - Reissue the ctrl request on failure > - Ensure Tx and ctrl requests are not interleaved > - Add promisc callbacks > > Obtained from: Hans Petter Selasky > > > +static void > +rum_update_mcast(struct ifnet *ifp) > +{ > + /* not supported */ > +} > This and similar additions for the other drivers are wrong. They don't implement the functionality which means multicast filtering will be silently broken. Drivers should only fill-in the callback if they do the work. If someone were to fix IFF_ALLMULTI support then net80211 could just fall back on it when drivers don't have or implement proper mcast filtering. A cursory scan shows some odd changes in places like vap_delete but don't have time to look closely. It appears the commit msg does not reflect the changes. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49A85BB9.4080304>