Date: Wed, 17 May 1995 13:51:20 -0700 (PDT)
From: Steven G Kargl <kargl@troutmask.apl.washington.edu>
To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes)
Cc: phk@ref.tfs.com, current@FreeBSD.org
Subject: Re: please test this patch for panic("swfree")
Message-ID: <199505172051.NAA00355@troutmask.apl.washington.edu>
In-Reply-To: <199505172008.NAA12294@gndrsh.aac.dev.com> from "Rodney W. Grimes" at May 17, 95 01:08:43 pm
next in thread | previous in thread | raw e-mail | index | archive | help
According to Rodney W. Grimes:
>
> >
> > for (dvbase = dmmax; dvbase < nblks; dvbase += dmmax) {
> > blk = nblks - dvbase;
> >
> > - if ((vsbase = index * dmmax + dvbase * nswdev) >= nswap)
> > - panic("swfree");
>
> Not Okay, please correct the calculation to do the right check, not
> eliminate the sanify check.
>
> > - if (blk > dmmax)
> > - blk = dmmax;
>
> Should this be another panic condition???
>
> > /* XXX -- we need to exclude the first cluster as above */
> > /* but for now, this will work fine... */
> > rlist_free(&swaplist, vsbase, vsbase + blk - 1);
> >
Yes, you get another panic.
panic: rlist_free: free start overlaps already freed area at list tail
--
Steven G. Kargl | Phone: 206-685-4677 |
Applied Physics Lab | Fax: 206-543-6785 |
Univ. of Washington |---------------------|
1013 NE 40th St | FreeBSD 2.1-current |
Seattle, WA 98105 |---------------------|
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199505172051.NAA00355>