Date: Tue, 18 Nov 2025 17:09:37 +0000 From: "Sergey A. Osokin" <osa@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: Daniel Engberg <diizzy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b4a4910b55ef - main - dns/aardvark-dns: add new port Message-ID: <aRyoUVLIvs3Tbqvh@FreeBSD.org> In-Reply-To: <CALH631mOVJRp-a-xWsfvoitD-CNVFtg2s1ArJ8zAcwPO54zk0g@mail.gmail.com> References: <691c97fb.3da01.9e98319@gitrepo.freebsd.org> <e7d75cd5-bac8-40e4-b193-f22ec17b5c6e@FreeBSD.org> <CALH631mOVJRp-a-xWsfvoitD-CNVFtg2s1ArJ8zAcwPO54zk0g@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Tue, Nov 18, 2025 at 07:49:01PM +0300, Gleb Popov wrote: > On Tue, Nov 18, 2025 at 7:42 PM Daniel Engberg <diizzy@freebsd.org> wrote: > > This is looks not ideal? :-) > > Why is libinotify always pulled in as a dependency if it's in base? > > For consistency with the rest of the tree probably better to use > > OSVERSION or OSREL/OSREL:R instead of just checking that it exists. > > Checking for file existence is actually more consistent - other > inotify-sensitive ports are already doing that. > But I agree that LIB_DEPENDS should be under the condition too. I do believe that USES should happen in this case, and all other things, linke checking if exists or doesn't + dependencies management should be done behind the scene. And, yes, that should happen for all new features are coming with future releases. -- Sergey A. Osokinhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aRyoUVLIvs3Tbqvh>