Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Nov 2025 16:34:26 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 4fbf901a2925 - stable/14 - openssh: Handle localtime_r() failure by return "UNKNOWN-TIME"
Message-ID:  <202511051634.5A5GYQl6047869@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/14 has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=4fbf901a2925ec2598167c1c4f04e78c06960869

commit 4fbf901a2925ec2598167c1c4f04e78c06960869
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2025-10-31 17:04:51 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2025-11-05 16:34:06 +0000

    openssh: Handle localtime_r() failure by return "UNKNOWN-TIME"
    
    Apply openssh-portable commit 8b6c1f402feb by deraadt@openbsd.org
    
    Obtained from:  openssh-portable
    PR:             288773
    Reported by:    wosch
    Sponsored by:   The FreeBSD Foundation
    
    (cherry picked from commit ce03706ab26c5770150f1ef96aca36b69baa535f)
    (cherry picked from commit 0a45aa9e954acc75484d59ad42ee440aa7f034c7)
---
 crypto/openssh/misc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/crypto/openssh/misc.c b/crypto/openssh/misc.c
index 1b4b55c5034d..e129218cdd5c 100644
--- a/crypto/openssh/misc.c
+++ b/crypto/openssh/misc.c
@@ -2534,8 +2534,10 @@ format_absolute_time(uint64_t t, char *buf, size_t len)
 	time_t tt = t > SSH_TIME_T_MAX ? SSH_TIME_T_MAX : t;
 	struct tm tm;
 
-	localtime_r(&tt, &tm);
-	strftime(buf, len, "%Y-%m-%dT%H:%M:%S", &tm);
+	if (localtime_r(&tt, &tm) == NULL)
+		strlcpy(buf, "UNKNOWN-TIME", len);
+	else
+		strftime(buf, len, "%Y-%m-%dT%H:%M:%S", &tm);
 }
 
 /*


help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202511051634.5A5GYQl6047869>