Date: Sat, 23 Aug 2025 08:59:07 +0200 From: Gordon Bergling <gbe@FreeBSD.org> To: ShengYi Hung <aokblast@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl Message-ID: <aKlmuxLpw2xqRonA@GB-MBA.local> In-Reply-To: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> References: <202508230450.57N4oxwG023161@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hi ShengYi, On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: > The branch main has been updated by aokblast: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1685192ea1faac28f2d4feede53e70b6a380500f > > commit 1685192ea1faac28f2d4feede53e70b6a380500f > Author: ShengYi Hung <aokblast@FreeBSD.org> > AuthorDate: 2025-08-21 17:59:15 +0000 > Commit: ShengYi Hung <aokblast@FreeBSD.org> > CommitDate: 2025-08-23 04:50:09 +0000 > > hkbd: remove erorr detection in KDSKBSTATE ioctl > > The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like qemu > keyboard) may not have LED or failed to set the LED due to unexpected reason. > Therefore, removing the error check as ukbd(4) does allow the keyboard works > correctly with kbdcontrol(4). > > Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can > disable setting LEDs > > PR: 288968 > Reviewed by: wulf > Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkellers@gmail.coom > Approved by: lwsu (mentor), markj (mentor) > MFC after 1 week > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D52101 > > mvalsmva > --- I am not sure how this is related, but since that commit, buildkernel of GENERIC is broken both on amd64 and aarch64. The following error is from an amd64 build, aarch64 is the same. ----------------------------- /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: called object type 'char[5]' is not a function or function pointer 1831 | DPRINTF(("error %d", error)); | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: expanded from macro 'DPRINTF' 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) | ~~~~~~~~~~~~^~~~~~~~~~~~ /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: expanded from macro 'DPRINTFN' 208 | printf("%s: " fmt, \ | ~~~~~~ ^ 1 error generated. --- hkbd.o --- *** [hkbd.o] Error code 1 ----------------------------- --Gordon [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEYbWI0KY5X7yH/Fy4OQX2V8rP09wFAmipZroACgkQOQX2V8rP 09zNDAgA93aa2y/C3lfrcOjRBRhNVkrIVJUuWmK0aHTXsZO7S8L9b+KlaceJ6DLO Y+/1SbcbsqmxqAV7lRJJ4aZkHCtQO73F2fYULzebJQohoH5Hmgw0RJWXUFCTId36 6Vk4F6OREMOS2fPorlhmZxcrv7fuxZwT4emLtgC+6aZcmnmqgWF/zrs7HGh6fCR7 DW+gPfTrkSCDICduPh2y0z+YEob6SVKQbMQM2YBgXEGq52/NZeZj8DKZGEc8tDjD YB1hFUQt02f43vHCF6UIOBnxtntdXwLHMVsFRHv4T/pQXiI9df4YrAy5OnRBApKN wBnHvMPqEYAcK91hmGI9SktOfYF+gw== =Kl6d -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aKlmuxLpw2xqRonA>