Date: Sun, 15 Jul 2012 00:09:17 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: "Justin T. Gibbs" <gibbs@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: PAM passwdqc, strict aliasing, and WARNS Message-ID: <86obnif10y.fsf@ds4.des.no> In-Reply-To: <F7FA2B4D-BD56-4EC4-9D93-B5AA847063D7@FreeBSD.org> (Justin T. Gibbs's message of "Fri, 13 Jul 2012 16:14:17 -0600") References: <F7FA2B4D-BD56-4EC4-9D93-B5AA847063D7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
"Justin T. Gibbs" <gibbs@FreeBSD.org> writes: > Someone who has yet to confess added -Werror to the global CFLAGS > (via /etc/make.conf) for one of our systems at work. Before I > figured out that this was the cause of builds failing, I hacked up > pam_passwdc to resolve the problem. This gets the module to > WARNS=3D2, but to go farther, the "logically const" issues with this > code will need to be sorted out. > > Is this change worth committing? Is this the best way to resolve > the strict aliasing issues in this code? I really don't like that sort of game. If you look at other PAM consumer code, you'll see that the common idiom is what Jilles suggested, i.e. use a temporary variable of the appropriate type. That being said, pam_passwdqc should probably be either updated or removed. The version we have is ten years old. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86obnif10y.fsf>