Date: Fri, 30 Aug 2013 16:55:36 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Hans Petter Selasky <hps@bitfrost.no> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r255067 - head/sys/kern Message-ID: <5220A458.3060202@FreeBSD.org> In-Reply-To: <5220A2DD.5040803@bitfrost.no> References: <201308301039.r7UAduI1052038@svn.freebsd.org> <5220A027.8070604@FreeBSD.org> <5220A2DD.5040803@bitfrost.no>
next in thread | previous in thread | raw e-mail | index | archive | help
on 30/08/2013 16:49 Hans Petter Selasky said the following: > On 08/30/13 15:37, Andriy Gapon wrote: >> on 30/08/2013 13:39 Hans Petter Selasky said the following: >>> Author: hselasky >>> Date: Fri Aug 30 10:39:56 2013 >>> New Revision: 255067 >>> URL: http://svnweb.freebsd.org/changeset/base/255067 >>> >>> Log: >>> Simplify pause_sbt() logic. Don't call DELAY() if remainder is less >>> than or equal to zero. >> >> Discussed with? >> Reviewed by? >> Tested by? >> > > Hi, > > I've checked MAINTAINERS first. > > A patch was sent to the freebsd-current mailing list, See XHCI USB debugging > thread. I noticed that you committed the patch just a few minutes after making it public. And later noticed that the patch did not result in any improvement. > Could probably have been discussed a bit more. Indeed. > The cold case logic for pause() > is mainly used by the USB code and was factored out from usb_pause_mtx() a long > while ago by me. Oh, I see. > Do you see anything technically wrong about my patch? I don't feel qualified enough. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5220A458.3060202>