Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Nov 2014 12:23:29 -0800
From:      Kirk McKusick <mckusick@mckusick.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        arch@freebsd.org, fs@freebsd.org
Subject:   Re: Removal of kern_xxx() no-at variants. 
Message-ID:  <201411122023.sACKNTm7087881@chez.mckusick.com>
In-Reply-To: <20141112132451.GM17068@kib.kiev.ua> 

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, November 12, 2014 8:24:52 am Konstantin Belousov wrote:

> We have 'fat' KPI for kern_open() and other vfs syscall helpers, after
> the at-version of the syscalls was added somewhere at 8-CURRENT.
> For instance, we provide
>       kern_open() and kern_openat().
> But more, we provide
>       kern_stat()
>       kern_lstat()
>       kern_statat()
>       kern_statat_vhook()
> first three being a trivial wrapper around kern_statat_vhook().
> More, existence of two or (sometimes) three layers around basic
> syscall helper causes issues like r271655 making the argument
> validation split.
>
> Kepping the compat layer was reasonable in 8-CURRENT time when the
> at variants were experimental and patch to add the syscalls was
> already large and error-prone.  Now, I think we should shave the
> extra call indirections, it costs nothing at callers and sometimes
> even improves the code.

I think this is an excellent idea and helps maintain the FreeBSD
philosophy of keeping its code base clean. I have reviewed the diffs 
and they all look good.

	Kirk McKusick



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201411122023.sACKNTm7087881>