Date: Sun, 30 Jan 2011 15:18:05 GMT From: Eitan Adler <lists@eitanadler.com> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/154395: [patch] remove obsolete Message-ID: <201101301518.p0UFI5Uc043988@red.freebsd.org> Resent-Message-ID: <201101301520.p0UFKBkx089937@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 154395
>Category: misc
>Synopsis: [patch] remove obsolete
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Jan 30 15:20:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Eitan Adler
>Release:
>Organization:
>Environment:
>Description:
grep -ER "{(SYSTEM|SYSLIB|LOCALLIB)DIR" /usr/ports
turns up only one port which depends on the 4 obsolete variables defined in bsd.gnustep.mk
I do not use gnustep so I am unable to test the following patch but the touched port along with a few other gnustep ports seem ok.
>How-To-Repeat:
>Fix:
Index: Mk/bsd.gnustep.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.gnustep.mk,v
retrieving revision 1.63
diff -u -r1.63 bsd.gnustep.mk
--- Mk/bsd.gnustep.mk 11 Jun 2010 09:12:37 -0000 1.63
+++ Mk/bsd.gnustep.mk 30 Jan 2011 14:48:27 -0000
@@ -189,12 +189,6 @@
GNUSTEP_LOCAL_TOOLS= ${GNUSTEP_LOCAL_ROOT}/Tools
GNUSTEP_LOCAL_SERVICES= ${GNUSTEP_LOCAL_ROOT}/Library/Services
-# Obsolete, for compatibility only
-SYSTEMDIR= ${GNUSTEP_SYSTEM_ROOT}
-SYSMAKEDIR= ${GNUSTEP_MAKEFILES}
-SYSLIBDIR= ${GNUSTEP_SYSTEM_LIBRARIES}
-LOCALLIBDIR= ${GNUSTEP_LOCAL_LIBRARIES}
-
.if defined(WITH_GNUSTEP_DEVEL)
PKGNAMESUFFIX?= -devel${PKGNAMESUFFIX2}
PLIST_SUB+= GNUSTEP_DEVEL=""
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-themes/etoile-camaelon/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- Makefile 5 Jun 2010 06:14:27 -0000 1.14
+++ Makefile 30 Jan 2011 14:54:14 -0000
@@ -36,9 +36,9 @@
@${CAT} ${PKGMESSAGE}
install-user:
- @(. ${SYSMAKEDIR}/GNUstep.sh && defaults write Camaelon Theme Nesedah)
+ @(. ${GNUSTEP_MAKEFILES}/GNUstep.sh && defaults write Camaelon Theme Nesedah)
deinstall-user:
- @(. ${SYSMAKEDIR}/GNUstep.sh && defaults delete Camaelon Theme)
+ @(. ${GNUSTEP_MAKEFILES}/GNUstep.sh && defaults delete Camaelon Theme)
.include <bsd.port.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101301518.p0UFI5Uc043988>