Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Sep 2011 16:36:04 -0400
From:      Ryan Steinmetz <zi@FreeBSD.org>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Janos Mohacsi <janos.mohacsi@bsd.hu>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/net-mgmt/ndpmon Makefile ports/net-mgmt/ndpmon/files ndpmonitor.in
Message-ID:  <20110925203510.GA928@fast.rit.edu>
In-Reply-To: <4E7F84A3.8000702@FreeBSD.org>
References:  <201109251647.p8PGl3Xm096164@repoman.freebsd.org> <4E7F84A3.8000702@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On (09/25/11 12:44), Doug Barton wrote:
> Overall the rc.d script looks good, just 2 questions.
> 
> 1. Is there a reason that it's got REQUIRE: DAEMON NETWORKING instead of
> the preferred REQUIRE: LOGIN?
> 2. Is there a reason that it does not have KEYWORD: shutdown? Since it
> seems to start a persistent daemon this is desirable.
> 
> 
> Doug
> 
> 
> On 09/25/2011 09:47, Ryan Steinmetz wrote:
> > zi          2011-09-25 16:47:03 UTC
> > 
> >   FreeBSD ports repository
> > 
> >   Modified files:
> >     net-mgmt/ndpmon      Makefile 
> >     net-mgmt/ndpmon/files ndpmonitor.in 
> >   Log:
> >   - Silence startup noise [1]
> >   - Fix build with custom PREFIX/LOCALBASE
> >   - Fix build when using CLANG
> >   - Add OPTIONS for MAC resolution
> >   - Add LICENSE
> >   
> >   PR:             ports/159915  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=159915
> >   Submitted by:   Janos Mohacsi <janos.mohacsi@bsd.hu> (maintainer) [1]
> >   
> >   Revision  Changes    Path
> >   1.10      +12 -2     ports/net-mgmt/ndpmon/Makefile
> >   1.5       +2 -2      ports/net-mgmt/ndpmon/files/ndpmonitor.in
> > 
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/ndpmon/Makefile.diff?&r1=1.9&r2=1.10&f=h
> > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/ndpmon/files/ndpmonitor.in.diff?&r1=1.4&r2=1.5&f=h
> > 
> 
> 
> 
> -- 
> 
> 	Nothin' ever doesn't change, but nothin' changes much.
> 			-- OK Go
> 
> 	Breadth of IT experience, and depth of knowledge in the DNS.
> 	Yours for the right price.  :)  http://SupersetSolutions.com/
> 

Doug,

1. No.  I believe the original author simply copied what was in
net-mgmt/arpwatch's rc script
2. No.  I believe this is the same case as #1.

An updated script will be committed shortly.  Thanks!

-r

-- 
Ryan Steinmetz
PGP: EF36 D45A 5CA9 28B1 A550  18CD A43C D111 7AD7 FAF2



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110925203510.GA928>