Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Jun 2009 15:54:34 +0000 (UTC)
From:      Robert Noland <rnoland@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r194725 - in stable/7/sys: . contrib/pf dev/drm
Message-ID:  <200906231554.n5NFsYhY081583@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rnoland
Date: Tue Jun 23 15:54:34 2009
New Revision: 194725
URL: http://svn.freebsd.org/changeset/base/194725

Log:
  Merge 190170 from HEAD
  
  vm_offset_t is unsigned, so compare of >= 0 is not needed.
  
  Found with:     Coverity Prevent(tm)
  CID:            2259

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/drm/drm_vm.c

Modified: stable/7/sys/dev/drm/drm_vm.c
==============================================================================
--- stable/7/sys/dev/drm/drm_vm.c	Tue Jun 23 15:53:17 2009	(r194724)
+++ stable/7/sys/dev/drm/drm_vm.c	Tue Jun 23 15:54:34 2009	(r194725)
@@ -54,7 +54,7 @@ int drm_mmap(struct cdev *kdev, vm_offse
 	if (file_priv && !file_priv->authenticated)
 		return EACCES;
 
-	if (dev->dma && offset >= 0 && offset < ptoa(dev->dma->page_count)) {
+	if (dev->dma && offset < ptoa(dev->dma->page_count)) {
 		drm_device_dma_t *dma = dev->dma;
 
 		DRM_SPINLOCK(&dev->dma_lock);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906231554.n5NFsYhY081583>