Date: Mon, 19 May 2014 09:26:50 -0600 From: Warner Losh <imp@bsdimp.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r266349 - in head: share/mk sys/conf Message-ID: <D3B7DA7F-0827-4082-88AB-D42223EF32E0@gmail.com> In-Reply-To: <20140518205605.70159532@bender.Home> References: <201405172031.s4HKVY51073386@svn.freebsd.org> <20140518205605.70159532@bender.Home>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 18, 2014, at 1:56 PM, Andrew Turner <andrew@fubar.geek.nz> wrote: > On Sat, 17 May 2014 20:31:34 +0000 (UTC) > Warner Losh <imp@FreeBSD.org> wrote: >=20 >> Author: imp >> Date: Sat May 17 20:31:34 2014 >> New Revision: 266349 >> URL: http://svnweb.freebsd.org/changeset/base/266349 >>=20 >> Log: >> The time is not yet ripe to break the lack of dependencies between >> src/sys and the rest of the tree for builds. >> o eliminate including bsd.mkopts.mk for the moment in kern.opts.mk >> o No need to include src.opts.mk at all anymore. The reasons for it >> are now coverted in sys.mk and src.sys.mk. >=20 > This breaks ARM kernel builds as MK_ARM_EABI is undefined, at least on > 9.x. The below patch fixes it for me. >=20 > Andrew >=20 > Index: sys/conf/kern.opts.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/conf/kern.opts.mk (revision 266414) > +++ sys/conf/kern.opts.mk (working copy) > @@ -16,6 +16,7 @@ > # src tree. >=20 > __DEFAULT_YES_OPTIONS =3D \ > + ARM_EABI \ > FORMAT_EXTENSIONS \ > KERNEL_SYMBOLS Yea, this will fix it. I=92ll commit the fix. But do we support (and have it work) building !EABI for ARM? If not, it = should be retired from the tree because it really is an ABI affecting = make option, of which there should be zero. If we want to support arm + = oabi, then that will need a new uname. I don=92t think we do, but we = could easily make armeb the only one to do this... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D3B7DA7F-0827-4082-88AB-D42223EF32E0>