Date: Sat, 24 Aug 2013 16:09:53 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r254793 - head/contrib/llvm/tools/lldb/source/Expression Message-ID: <201308241609.r7OG9rYY007105@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste Date: Sat Aug 24 16:09:52 2013 New Revision: 254793 URL: http://svnweb.freebsd.org/changeset/base/254793 Log: Revert lldb change for Attribute::NoBuiltin NoBuiltin was introduced after clang/llvm 3.3 and thus does not exist in FreeBSD. Thus special handling for the attribute is not needed in lldb. This reverts lldb r186990 (git eebd175) Sponsored by: DARPA, AFRL Modified: head/contrib/llvm/tools/lldb/source/Expression/IRForTarget.cpp Modified: head/contrib/llvm/tools/lldb/source/Expression/IRForTarget.cpp ============================================================================== --- head/contrib/llvm/tools/lldb/source/Expression/IRForTarget.cpp Sat Aug 24 15:47:15 2013 (r254792) +++ head/contrib/llvm/tools/lldb/source/Expression/IRForTarget.cpp Sat Aug 24 16:09:52 2013 (r254793) @@ -356,20 +356,6 @@ IRForTarget::ResolveFunctionPointers(llv if (value_ptr) *value_ptr = value; - - // If we are replacing a function with the nobuiltin attribute, it may - // be called with the builtin attribute on call sites. Remove any such - // attributes since it's illegal to have a builtin call to something - // other than a nobuiltin function. - if (fun->hasFnAttribute(Attribute::NoBuiltin)) { - Attribute builtin = Attribute::get(fun->getContext(), Attribute::Builtin); - - for (auto u = fun->use_begin(), e = fun->use_end(); u != e; ++u) { - if (auto call = dyn_cast<CallInst>(*u)) { - call->removeAttribute(AttributeSet::FunctionIndex, builtin); - } - } - } fun->replaceAllUsesWith(value); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201308241609.r7OG9rYY007105>