Date: Tue, 21 Feb 2023 02:33:10 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Daniel Engberg <diizzy@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 23e0e7b1c30f - main - multimedia/mediainfo: Use all-in-one tarball Message-ID: <CAMHz58Qi9mdddkE0f30N_2J-7QE628DkRt499iYRQMsvhyoT4g@mail.gmail.com> In-Reply-To: <a499acc17d7f0a4151dcc459f09bffef@FreeBSD.org> References: <202301301306.30UD63Np053142@gitrepo.freebsd.org> <a499acc17d7f0a4151dcc459f09bffef@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg <diizzy@freebsd.org> wrote: > Hi, > > Porters Handbook (indirectly) recommends you to sanitize sources. > > https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements Do you mean the removal of USES=dos2unix? This port does not install any text file but only 1 binary executable. Therefore USES=dos2unix is unnecessary. I also checked that the generated bin/mediainfo are identical. > Best regards, > Daniel > > On 2023-01-30 14:06, Po-Chuan Hsieh wrote: > > The branch main has been updated by sunpoet: > > > > URL: > > > https://cgit.FreeBSD.org/ports/commit/?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291 > > > > commit 23e0e7b1c30fc6f86957a7428e51a5ea9c594291 > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2023-01-30 12:27:47 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2023-01-30 12:59:06 +0000 > > > > multimedia/mediainfo: Use all-in-one tarball > > > > - Update WWW > > - Remove unnecessary USES=dos2unix > > --- > > multimedia/mediainfo/Makefile | 20 +++++++++----------- > > multimedia/mediainfo/distinfo | 6 +++--- > > 2 files changed, 12 insertions(+), 14 deletions(-) > > > > diff --git a/multimedia/mediainfo/Makefile > > b/multimedia/mediainfo/Makefile > > index 5766752579b5..9b7c3737d89f 100644 > > --- a/multimedia/mediainfo/Makefile > > +++ b/multimedia/mediainfo/Makefile > > @@ -1,13 +1,14 @@ > > PORTNAME= mediainfo > > -DISTVERSION= 22.12 > > +PORTVERSION= 22.12 > > CATEGORIES= multimedia > > -MASTER_SITES= > https://mediaarea.net/download/source/${PORTNAME}/${DISTVERSION}/ > > \ > > +MASTER_SITES= > https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/ > > \ > > LOCAL/sunpoet > > -DISTNAME= ${PORTNAME}_${DISTVERSION} > > +DISTNAME= MediaInfo_CLI_${PORTVERSION}_GNU_FromSource > > > > MAINTAINER= sunpoet@FreeBSD.org > > COMMENT= Provides technical and tag information for video and audio > > files > > -WWW= https://mediaarea.net/en/MediaInfo > > +WWW= https://mediaarea.net/en/MediaInfo \ > > + https://github.com/MediaArea/MediaInfo > > > > LICENSE= BSD2CLAUSE > > LICENSE_FILE= ${WRKSRC}/../../../License.html > > @@ -15,17 +16,14 @@ LICENSE_FILE= ${WRKSRC}/../../../License.html > > LIB_DEPENDS= libmediainfo.so:multimedia/libmediainfo \ > > libzen.so:multimedia/libzen > > > > -USES= autoreconf compiler:c++11-lang cpe dos2unix > libtool pathfix \ > > - pkgconfig tar:xz > > +USES= compiler:c++11-lang cpe libtool pathfix pkgconfig > tar:xz > > > > GNU_CONFIGURE= yes > > -USE_CXXSTD= c++11 > > USE_LDCONFIG= yes > > -CPE_VENDOR= mediaarea > > -DOS2UNIX_GLOB= *.c *.cpp *.h > > -DOS2UNIX_WRKSRC= ${WRKDIR} > > > > PLIST_FILES= bin/mediainfo > > -WRKSRC= ${WRKDIR}/MediaInfo/Project/GNU/CLI > > +WRKSRC= > ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI > > + > > +CPE_VENDOR= mediaarea > > > > .include <bsd.port.mk> > > diff --git a/multimedia/mediainfo/distinfo > > b/multimedia/mediainfo/distinfo > > index 0d9caebdc92b..995778948454 100644 > > --- a/multimedia/mediainfo/distinfo > > +++ b/multimedia/mediainfo/distinfo > > @@ -1,3 +1,3 @@ > > -TIMESTAMP = 1672606752 > > -SHA256 (mediainfo_22.12.tar.xz) = > > 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc > > -SIZE (mediainfo_22.12.tar.xz) = 2026408 > > +TIMESTAMP = 1674589524 > > +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = > > e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef1106947 > > +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = 3352944 > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr">On Sat, Feb 11, 2023 at 3:43 PM Daniel Engberg <<a href="mailto:diizzy@freebsd.org" target="_blank">diizzy@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br> <br> Porters Handbook (indirectly) recommends you to sanitize sources.<br> <a href="https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements" rel="noreferrer" target="_blank">https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-automatic-replacements</a></blockquote><div><br></div><div>Do you mean the removal of USES=dos2unix?</div><div>This port does not install any text file but only 1 binary executable.</div><div>Therefore USES=dos2unix is unnecessary.</div><div><br></div><div>I also checked that the generated bin/mediainfo are identical.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> Best regards,<br> Daniel<br> <br> On 2023-01-30 14:06, Po-Chuan Hsieh wrote:<br> > The branch main has been updated by sunpoet:<br> > <br> > URL:<br> > <a href="https://cgit.FreeBSD.org/ports/commit/?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291</a><br>; > <br> > commit 23e0e7b1c30fc6f86957a7428e51a5ea9c594291<br> > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > AuthorDate: 2023-01-30 12:27:47 +0000<br> > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org><br> > CommitDate: 2023-01-30 12:59:06 +0000<br> > <br> > multimedia/mediainfo: Use all-in-one tarball<br> > <br> > - Update WWW<br> > - Remove unnecessary USES=dos2unix<br> > ---<br> > multimedia/mediainfo/Makefile | 20 +++++++++-----------<br> > multimedia/mediainfo/distinfo | 6 +++---<br> > 2 files changed, 12 insertions(+), 14 deletions(-)<br> > <br> > diff --git a/multimedia/mediainfo/Makefile <br> > b/multimedia/mediainfo/Makefile<br> > index 5766752579b5..9b7c3737d89f 100644<br> > --- a/multimedia/mediainfo/Makefile<br> > +++ b/multimedia/mediainfo/Makefile<br> > @@ -1,13 +1,14 @@<br> > PORTNAME= mediainfo<br> > -DISTVERSION= 22.12<br> > +PORTVERSION= 22.12<br> > CATEGORIES= multimedia<br> > -MASTER_SITES= <a href="https://mediaarea.net/download/source/$%7BPORTNAME%7D/$%7BDISTVERSION%7D/" rel="noreferrer" target="_blank">https://mediaarea.net/download/source/${PORTNAME}/${DISTVERSION}/</a><br>; > \<br> > +MASTER_SITES= <a href="https://mediaarea.net/download/binary/mediainfo/$%7BPORTVERSION%7D/" rel="noreferrer" target="_blank">https://mediaarea.net/download/binary/mediainfo/${PORTVERSION}/</a>; <br> > \<br> > LOCAL/sunpoet<br> > -DISTNAME= ${PORTNAME}_${DISTVERSION}<br> > +DISTNAME= MediaInfo_CLI_${PORTVERSION}_GNU_FromSource<br> > <br> > MAINTAINER= sunpoet@FreeBSD.org<br> > COMMENT= Provides technical and tag information for video and audio <br> > files<br> > -WWW= <a href="https://mediaarea.net/en/MediaInfo" rel="noreferrer" target="_blank">https://mediaarea.net/en/MediaInfo</a><br>; > +WWW= <a href="https://mediaarea.net/en/MediaInfo" rel="noreferrer" target="_blank">https://mediaarea.net/en/MediaInfo</a>; \<br> > + <a href="https://github.com/MediaArea/MediaInfo" rel="noreferrer" target="_blank">https://github.com/MediaArea/MediaInfo</a><br>; > <br> > LICENSE= BSD2CLAUSE<br> > LICENSE_FILE= ${WRKSRC}/../../../License.html<br> > @@ -15,17 +16,14 @@ LICENSE_FILE= ${WRKSRC}/../../../License.html<br> > LIB_DEPENDS= libmediainfo.so:multimedia/libmediainfo \<br> > libzen.so:multimedia/libzen<br> > <br> > -USES= autoreconf compiler:c++11-lang cpe dos2unix libtool pathfix \<br> > - pkgconfig tar:xz<br> > +USES= compiler:c++11-lang cpe libtool pathfix pkgconfig tar:xz<br> > <br> > GNU_CONFIGURE= yes<br> > -USE_CXXSTD= c++11<br> > USE_LDCONFIG= yes<br> > -CPE_VENDOR= mediaarea<br> > -DOS2UNIX_GLOB= *.c *.cpp *.h<br> > -DOS2UNIX_WRKSRC= ${WRKDIR}<br> > <br> > PLIST_FILES= bin/mediainfo<br> > -WRKSRC= ${WRKDIR}/MediaInfo/Project/GNU/CLI<br> > +WRKSRC= ${WRKDIR}/MediaInfo_CLI_GNU_FromSource/MediaInfo/Project/GNU/CLI<br> > +<br> > +CPE_VENDOR= mediaarea<br> > <br> > .include <<a href="http://bsd.port.mk" rel="noreferrer" target="_blank">bsd.port.mk</a>><br> > diff --git a/multimedia/mediainfo/distinfo <br> > b/multimedia/mediainfo/distinfo<br> > index 0d9caebdc92b..995778948454 100644<br> > --- a/multimedia/mediainfo/distinfo<br> > +++ b/multimedia/mediainfo/distinfo<br> > @@ -1,3 +1,3 @@<br> > -TIMESTAMP = 1672606752<br> > -SHA256 (mediainfo_22.12.tar.xz) =<br> > 932b82739f738e7db603cf5bb170720731a9e7c61d145c2a54aabb3cd0b753bc<br> > -SIZE (mediainfo_22.12.tar.xz) = 2026408<br> > +TIMESTAMP = 1674589524<br> > +SHA256 (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) =<br> > e67ce7419ec6af9fb54ffbe3164a42ae1cd874a7e559bfff017868cef1106947<br> > +SIZE (MediaInfo_CLI_22.12_GNU_FromSource.tar.xz) = 3352944<br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Qi9mdddkE0f30N_2J-7QE628DkRt499iYRQMsvhyoT4g>