Date: Thu, 9 Aug 2018 17:40:54 -0600 From: Warner Losh <imp@bsdimp.com> To: Scott Long <scottl@samsco.org> Cc: Conrad Meyer <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337554 - in head/sys/cam: . ata nvme scsi Message-ID: <CANCZdfpLzbDjOgV-5RCt2UEQb0trbfpJ9x7bWYR8Tu4nms197A@mail.gmail.com> In-Reply-To: <B55AF4CC-7C6A-4303-B5BC-2D1CEAC56743@samsco.org> References: <201808092153.w79LrWEZ097986@repo.freebsd.org> <B55AF4CC-7C6A-4303-B5BC-2D1CEAC56743@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 9, 2018 at 3:56 PM, Scott Long <scottl@samsco.org> wrote: > > > > On Aug 9, 2018, at 3:53 PM, Conrad Meyer <cem@FreeBSD.org> wrote: > > > > Author: cem > > Date: Thu Aug 9 21:53:32 2018 > > New Revision: 337554 > > URL: https://svnweb.freebsd.org/changeset/base/337554 > > > > Log: > > cam(4): Add an xpt-neutral flag indicating a valid panic CCB > > > > No functional change. > > > > Note that this change is careful to set the CCB header xflags after > > foo_fill_bar() routines, which generally zero existing flags. An > earlier > > version of this patch mistakenly set the flag before the fill routines= . > > > > Submitted by: Scott Ferris <sferris AT isilon.com>, jhibbits@ > > Reviewed by: bdrewery@, markj@, and non-committer FreeBSD contributor > Anton Rang > > Sponsored by: Dell EMC Isilon > > What=E2=80=99s the purpose of this flag? I see it gets set in plenty of = places, > but never checked. > It kinda looks like something I recall removing when I did the runccb fixes so they worked when we were dumping. We used to need this, but we don't anymore. I have the same question: Why? Maybe these CAM changes should go through phabricator? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpLzbDjOgV-5RCt2UEQb0trbfpJ9x7bWYR8Tu4nms197A>