Date: Sat, 28 Jul 2007 17:52:37 +0800 From: Rong-En Fan <rafan@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Chris Cowart <ccowart@rescomp.berkeley.edu>, cvs-all@FreeBSD.org, Rong-En Fan <rafan@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/net-snmp4 Makefile pkg-plist ports/net-mgmt/net-snmp4/files snmpd.in snmpd.sh.sample Message-ID: <20070728095237.GS88047@svm.csie.ntu.edu.tw> In-Reply-To: <46AA65F6.2000204@FreeBSD.org> References: <200707271159.l6RBxTwp090951@repoman.freebsd.org> <46AA65F6.2000204@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Jul 27, 2007 at 02:39:02PM -0700, Doug Barton wrote: > Rong-En Fan wrote: > > rafan 2007-07-27 11:59:29 UTC > > > > FreeBSD ports repository > > > > Modified files: > > net-mgmt/net-snmp4 Makefile pkg-plist > > Added files: > > net-mgmt/net-snmp4/files snmpd.in > > Removed files: > > net-mgmt/net-snmp4/files snmpd.sh.sample > > Log: > > - Convert to rc.d style script > > - Bump PORTREVISION > > > > Note that I changed few places of the patch to match Porter's Handbook. > > > > PR: ports/114952 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=114952 > > Submitted by: Chris Cowart <ccowart at rescomp.berkeley.edu> > > > > Revision Changes Path > > 1.106 +2 -6 ports/net-mgmt/net-snmp4/Makefile > > 1.1 +26 -0 ports/net-mgmt/net-snmp4/files/snmpd.in (new) > > 1.2 +0 -20 ports/net-mgmt/net-snmp4/files/snmpd.sh.sample (dead) > > 1.24 +0 -1 ports/net-mgmt/net-snmp4/pkg-plist > > > > This looks good overall. One question, it looks like this script is > starting a service, would it benefit from the shutdown KEYWORD? Not quite sure whether we should add it. Both net-mgmt/net-snmp and base's bsnmpd do not have this keyword. Keep this daemon running during shutdown process may not be a bad idea, i.e. you can still monitoring the target system. Regards, Rong-En Fan > > Doug > > -- > > This .signature sanitized for your protection [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFGqxHl144QkYb9jGgRAmtFAJ9c+cjCHX9GrtTUNw5YvLptv8HhegCePgJO Jj3bekfwFRT6NxeB9e3CmKU= =eFKm -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070728095237.GS88047>