Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 2 Mar 2023 15:12:50 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 0715ec7eb475 - main - usbconfig: Remove useless return at the end of void function
Message-ID:  <202303021512.322FCosF038097@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=0715ec7eb4759489b68b651a205922a6564ed798

commit 0715ec7eb4759489b68b651a205922a6564ed798
Author:     Elyes Haouas <ehaouas@noos.fr>
AuthorDate: 2023-03-02 14:59:07 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-03-02 15:01:39 +0000

    usbconfig: Remove useless return at the end of void function
    
    Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
    Reviewed by: imp
    Pull Request: https://github.com/freebsd/freebsd-src/pull/656
---
 usr.sbin/usbconfig/dump.c      | 7 -------
 usr.sbin/usbconfig/usbconfig.c | 5 -----
 2 files changed, 12 deletions(-)

diff --git a/usr.sbin/usbconfig/dump.c b/usr.sbin/usbconfig/dump.c
index 4a52ab9fd85e..84de721a4fc9 100644
--- a/usr.sbin/usbconfig/dump.c
+++ b/usr.sbin/usbconfig/dump.c
@@ -264,7 +264,6 @@ dump_extra(struct libusb20_me_struct *str, const char *plevel)
 		}
 		printf("\n");
 	}
-	return;
 }
 
 static void
@@ -276,7 +275,6 @@ dump_endpoint(struct libusb20_device *pdev,
 	edesc = &ep->desc;
 	LIBUSB20_ENDPOINT_DESC(DUMP3, edesc);
 	dump_extra(&ep->extra, "  " "  " "  ");
-	return;
 }
 
 static void
@@ -294,7 +292,6 @@ dump_iface(struct libusb20_device *pdev,
 		printf("\n     Endpoint %u\n", z);
 		dump_endpoint(pdev, iface->endpoints + z);
 	}
-	return;
 }
 
 void
@@ -353,7 +350,6 @@ dump_be_quirk_names(struct libusb20_backend *pbe)
 			printf("%s\n", q.quirkname);
 	}
 	printf("\n");
-	return;
 }
 
 void
@@ -385,7 +381,6 @@ dump_be_dev_quirks(struct libusb20_backend *pbe)
 		}
 	}
 	printf("\n");
-	return;
 }
 
 void
@@ -395,7 +390,6 @@ dump_device_desc(struct libusb20_device *pdev)
 
 	ddesc = libusb20_dev_get_device_desc(pdev);
 	LIBUSB20_DEVICE_DESC(DUMP0, ddesc);
-	return;
 }
 
 void
@@ -444,7 +438,6 @@ dump_config(struct libusb20_device *pdev, uint8_t all_cfg)
 		printf("\n");
 		free(pcfg);
 	}
-	return;
 }
 
 void
diff --git a/usr.sbin/usbconfig/usbconfig.c b/usr.sbin/usbconfig/usbconfig.c
index 81112d957bbb..06aafc06cde6 100644
--- a/usr.sbin/usbconfig/usbconfig.c
+++ b/usr.sbin/usbconfig/usbconfig.c
@@ -182,7 +182,6 @@ be_dev_remove_quirk(struct libusb20_backend *pbe,
 	if (error) {
 		fprintf(stderr, "Removing quirk '%s' failed, continuing.\n", str);
 	}
-	return;
 }
 
 static void
@@ -205,7 +204,6 @@ be_dev_add_quirk(struct libusb20_backend *pbe,
 	if (error) {
 		fprintf(stderr, "Adding quirk '%s' failed, continuing.\n", str);
 	}
-	return;
 }
 
 static uint8_t
@@ -312,7 +310,6 @@ reset_options(struct options *opt)
 	if (opt->buffer)
 		free(opt->buffer);
 	memset(opt, 0, sizeof(*opt));
-	return;
 }
 
 static void
@@ -542,8 +539,6 @@ flush_command(struct libusb20_backend *pbe, struct options *opt)
 	}
 done:
 	reset_options(opt);
-
-	return;
 }
 
 int

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303021512.322FCosF038097>