Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Sep 2019 03:05:39 +0000
From:      Rick Macklem <rmacklem@uoguelph.ca>
To:        Rick Macklem <rmacklem@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r351901 - head/sys/fs/nfsserver
Message-ID:  <YT1PR01MB2907A509D2C9A0AF0DF581BFDDBA0@YT1PR01MB2907.CANPRD01.PROD.OUTLOOK.COM>
In-Reply-To: <201909052225.x85MPJ9o004838@repo.freebsd.org>
References:  <201909052225.x85MPJ9o004838@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

Rick Macklem wrote:
>Author: rmacklem
>Date: Thu Sep  5 22:25:19 2019
>New Revision: 351901
>URL: https://svnweb.freebsd.org/changeset/base/351901
>
>Log:
>  Delete the unused "nd" argument for nfsrv_proxyds().
>
>  The "nd" argument for nfsrv_proxyds() is no longer used by the function.
>  This patch deletes it. This allows a subsequent patch to delete the "nd"
>  argument from nfsvno_getattr(), since it's only use of "nd" was to pass it
>  to nfsrv_proxyds().
>  Getting rid of the "nd" argument from nfsvno_getattr() avoids confusion
>  over why it might need "nd".

Actually, I just looked and nfsvno_getattr() still uses the "nd" argument.
However, the other uses are straightforward, so I think getting rid of the
unused "nd" argument for nfsrv_proxyds() will simplify the code.

rick





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YT1PR01MB2907A509D2C9A0AF0DF581BFDDBA0>