Date: Mon, 8 Jul 2024 23:39:27 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 53734ccd4261 - main - Potential typo/copy issue Message-ID: <202407082339.468NdRmZ033637@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=53734ccd42614e48ae227f88161af89c807cdbcf commit 53734ccd42614e48ae227f88161af89c807cdbcf Author: Ted Spence <ted@spence.net> AuthorDate: 2024-07-05 04:22:42 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2024-07-08 23:36:03 +0000 Potential typo/copy issue This test here appears to be clamping the start and stop values to a minimum and maximum. But it looks like one of these lines may have been copied incorrectly. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1317 --- sys/dev/cxgb/cxgb_sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index a2b3918032bb..1b82f2ebcaae 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -266,7 +266,7 @@ check_pkt_coalesce(struct sge_qset *qs) if (cxgb_tx_coalesce_enable_start > COALESCE_START_MAX) cxgb_tx_coalesce_enable_start = COALESCE_START_MAX; if (cxgb_tx_coalesce_enable_stop < COALESCE_STOP_MIN) - cxgb_tx_coalesce_enable_start = COALESCE_STOP_MIN; + cxgb_tx_coalesce_enable_stop = COALESCE_STOP_MIN; /* * if the hardware transmit queue is more than 1/8 full * we mark it as coalescing - we drop back from coalescing
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202407082339.468NdRmZ033637>