Date: Mon, 23 Oct 2000 22:36:58 +1000 (EST) From: andrew@ugh.net.au To: ru@FreeBSD.org Cc: freebsd-bugs@FreeBSD.org Subject: Re: bin/22187: silence a warning from gcc when compiling finger Message-ID: <Pine.BSF.4.21.0010232232530.45919-100000@starbug.ugh.net.au> In-Reply-To: <200010231221.FAA53252@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Oct 2000 ru@FreeBSD.org wrote:
> Fixed, but why did you remove the (ch == ' ') test in your patch?
From the description of the original PR:
This patch also removes the test for ch being a space
as that will already have been caught by isprint(ch)
Its just for a tiny bit of efficiency. It should have no functional
change. The idea is that if ch is a space then isprint(ch) will be true
and the second half (the part after the ||) will never be executed. If we
are in the part after the || we already know ch != ' ' so there is no
point in testing it.
Thanks,
Andrew
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0010232232530.45919-100000>