Date: Sun, 7 Sep 2014 22:32:33 +0100 From: "Steven Hartland" <smh@freebsd.org> To: "Andriy Gapon" <avg@FreeBSD.org>, "Slawa Olhovchenkov" <slw@zxy.spb.ru> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r260713 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <E8622D8521554927BD02AA882F0FB843@multiplay.co.uk> References: <201401161324.s0GDOADB008512@svn.freebsd.org> <20140907155641.GB72244@zxy.spb.ru> <540CC991.3070604@FreeBSD.org> <00D872A5601148E8AB294954A163BEBD@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message ----- From: "Steven Hartland" >> on 07/09/2014 18:56 Slawa Olhovchenkov said the following: >>> On Thu, Jan 16, 2014 at 01:24:10PM +0000, Andriy Gapon wrote: >>> >>>> Author: avg >>>> Date: Thu Jan 16 13:24:10 2014 >>>> New Revision: 260713 >>>> URL: http://svnweb.freebsd.org/changeset/base/260713 >>>> >>>> Log: >>>> fix a bug in ZFS mirror code for handling multiple DVAa >>>> >>>> The bug was introduced in r256956 "Improve ZFS N-way mirror read >>>> performance". >>>> The code in vdev_mirror_dva_select erroneously considers already >>>> tried DVAs for the next attempt. Thus, it is possible that a failing DVA >>>> would be retried forever. >>>> As a secondary effect, if the attempts fail with checksum error, then >>>> checksum error reports are accumulated until the original request >>>> ultimately fails or succeeds. But because retrying is going on indefinitely >>>> the cheksum reports accumulation will effectively be a memory leak. >>>> >>>> Reviewed by: gibbs >>>> MFC after: 13 days >>>> Sponsored by: HybridCluster >>> >>> No NFC yet >>> >> >> Is r256956 MFC-ed yet? > > Nope I missed it, have applied for both to be MFC'ed. Approval was granted, both have now been MFC'ed. Thanks Slawa for heads up that I missed that one. Regards Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E8622D8521554927BD02AA882F0FB843>