Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 19 Jul 2025 17:09:02 GMT
From:      Zhenlei Huang <zlei@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: f46e95ae3add - main - if_genet: Plug memory leaks
Message-ID:  <202507191709.56JH9231065089@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=f46e95ae3addc9f7b975c187f71125825a38ffb1

commit f46e95ae3addc9f7b975c187f71125825a38ffb1
Author:     Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2025-07-19 17:07:54 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2025-07-19 17:07:54 +0000

    if_genet: Plug memory leaks
    
    The rx_buf_tag should be checked when destroying rx dma mappings.
    
    PR:             288309
    Reviewed by:    zlei
    Submitted by:   Mike Belanger <mibelanger@qnx.com>
    MFC after:      3 days
---
 sys/arm64/broadcom/genet/if_genet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/arm64/broadcom/genet/if_genet.c b/sys/arm64/broadcom/genet/if_genet.c
index da973a778706..182b5582fb7c 100644
--- a/sys/arm64/broadcom/genet/if_genet.c
+++ b/sys/arm64/broadcom/genet/if_genet.c
@@ -653,7 +653,7 @@ gen_bus_dma_teardown(struct gen_softc *sc)
 			    error);
 	}
 
-	if (sc->tx_buf_tag != NULL) {
+	if (sc->rx_buf_tag != NULL) {
 		for (i = 0; i < RX_DESC_COUNT; i++) {
 			error = bus_dmamap_destroy(sc->rx_buf_tag,
 			    sc->rx_ring_ent[i].map);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202507191709.56JH9231065089>